Skip to content

Fixed parquet reader when reading multiple data pages#1186

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/parquet-reading-page-headers
Aug 12, 2024
Merged

Fixed parquet reader when reading multiple data pages#1186
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/parquet-reading-page-headers

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • parquet reader when reading multiple data pages

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 3.951mb +0.01%  | 510.498ms -0.28% | ±0.72% +302.48% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.084mb +0.01%  | 1.065s -0.07%    | ±0.61% +13.08%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 28.546mb +0.15% | 442.891ms +3.35% | ±0.77% +242.32% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 3.711mb +0.01%  | 34.238ms +0.14%  | ±1.37% -14.72%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 3.701mb +0.01%  | 761.325ms -2.09% | ±1.28% -10.11%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.053mb +0.00% | 59.626ms +0.35% | ±0.34% -26.55% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.213mb +0.00%  | 140.789ms +1.81% | ±0.81% -53.69%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 89.825mb +0.00%  | 116.783ms +1.56% | ±0.81% -31.27%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 123.825mb +0.04% | 1.234s +1.39%    | ±0.45% +96.30%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.968mb +0.00%  | 44.108ms +0.16%  | ±0.98% +159.08% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 52.633mb +0.00%  | 389.109ms +0.34% | ±2.69% +580.87%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 12.899mb +0.00%  | 80.091ms +2.84%  | ±3.58% +570.82%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 106.826mb +0.00% | 475.381ms +1.62% | ±0.02% -98.08%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.184mb +0.00%  | 240.165ms +2.14% | ±0.56% +2.45%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.022mb +0.00%  | 52.608ms +2.89%  | ±1.99% +202.08%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 86.809mb +0.00%  | 3.736ms +16.35%  | ±2.06% +34.64%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.412mb +0.00% | 184.470ms -2.80% | ±0.72% -7.64%    |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.132mb +0.00%  | 18.828ms -0.08%  | ±0.62% +40.73%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.049mb +0.00%  | 1.930ms +14.28%  | ±2.32% +93.29%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.049mb +0.00%  | 1.964ms +17.14%  | ±1.69% +190.18%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.161mb +0.00%  | 2.787ms +7.26%   | ±1.48% -40.20%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.690mb +0.00%  | 16.553ms +6.71%  | ±0.76% -27.67%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.690mb +0.00%  | 16.585ms +4.80%  | ±0.59% +21.69%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.594mb +0.00%  | 1.994μs +11.15%  | ±2.40% -10.17%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.594mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 92.944mb +0.00%  | 13.247ms +4.44%  | ±1.01% -66.53%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.315mb +0.00% | 60.453ms -1.46%  | ±0.85% +85.86%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.210mb +0.00%  | 1.645ms +33.30%  | ±3.27% +91.30%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.561mb +0.00%  | 64.394ms +2.01%  | ±0.21% -75.43%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.311mb +0.00%  | 4.369ms +12.59%  | ±2.42% +230.42%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 83.743mb +0.00%  | 40.593ms +1.92%  | ±0.96% -70.61%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 83.744mb +0.00%  | 40.431ms +1.15%  | ±1.40% -12.36%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 83.743mb +0.00%  | 40.618ms +4.64%  | ±1.41% +1025.64% |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.035mb +0.00%  | 7.664ms +4.60%   | ±1.95% +577.81%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.594mb +0.00%  | 28.422ms -2.14%  | ±1.15% +79.73%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.594mb +0.00%  | 13.860μs +3.74%  | ±2.06% -40.48%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.594mb +0.00%  | 16.356μs +2.94%  | ±2.24% +36.86%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.414mb +0.00% | 187.954ms -2.74% | ±1.52% +214.15%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit 5ecf972 into flow-php:1.x Aug 12, 2024
@norberttech norberttech deleted the bug/parquet-reading-page-headers branch December 5, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant