Skip to content

Fixed wrong saving multiple rows in JsonLoader#1189

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
stloyd:bugfix/json-multi
Aug 13, 2024
Merged

Fixed wrong saving multiple rows in JsonLoader#1189
norberttech merged 1 commit intoflow-php:1.xfrom
stloyd:bugfix/json-multi

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Aug 13, 2024

Change Log

Added

Fixed

  • Fixed wrong saving multiple rows in `JsonLoader`

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.350mb +0.00%  | 510.272ms -0.87% | ±0.14% -95.93%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.483mb +0.00%  | 1.057s -1.23%    | ±0.83% +120.79% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 28.988mb +0.00% | 435.326ms -0.23% | ±2.64% +501.39% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.110mb +0.00%  | 33.511ms -1.57%  | ±0.79% -51.97%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.099mb +0.00%  | 752.439ms -0.75% | ±0.75% -58.23%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.451mb +0.00% | 60.452ms -3.07% | ±0.78% +195.12% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.611mb +0.00%  | 140.810ms -0.06% | ±0.19% -36.62%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.224mb +0.00%  | 117.502ms +0.08% | ±0.11% -70.56%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 124.272mb +0.00% | 1.234s -0.77%    | ±0.37% +66.82%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.367mb +0.00%  | 44.198ms -0.87%  | ±0.50% +101.47% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.032mb +0.00%  | 390.058ms -6.33% | ±3.49% +167.97% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.298mb +0.00%  | 79.746ms -6.28%  | ±2.78% -3.66%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.225mb +0.00% | 470.797ms -1.36% | ±1.19% +13.14%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.583mb +0.00%  | 237.235ms +0.13% | ±0.65% +89.37%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.421mb +0.00%  | 51.809ms -1.30%  | ±1.39% +16.66%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.208mb +0.00%  | 3.603ms -10.77%  | ±1.32% -39.43%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.811mb +0.00% | 185.058ms +0.18% | ±0.24% -66.96%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.531mb +0.00%  | 18.822ms -0.14%  | ±0.67% +27.27%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.448mb +0.00%  | 2.024ms +7.63%   | ±2.04% +62.29%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.448mb +0.00%  | 2.030ms -7.32%   | ±2.15% -21.33%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.560mb +0.00%  | 2.951ms -5.68%   | ±0.44% -77.16%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.089mb +0.00%  | 16.676ms -2.27%  | ±0.33% -46.84%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.089mb +0.00%  | 16.715ms -1.65%  | ±0.20% -67.19%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.993mb +0.00%  | 1.694μs -0.36%   | ±2.83% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.993mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00% |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.343mb +0.00%  | 12.342ms -4.11%  | ±1.19% -25.09%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.714mb +0.00% | 61.923ms -2.20%  | ±0.28% -62.68%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.608mb +0.00%  | 1.732ms -12.45%  | ±1.66% -28.36%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.960mb +0.00%  | 66.462ms +1.38%  | ±1.87% +33.76%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.710mb +0.00%  | 4.564ms -9.62%   | ±0.94% -73.77%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.142mb +0.00%  | 39.307ms -5.43%  | ±0.14% -92.20%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.143mb +0.00%  | 41.370ms +0.80%  | ±0.92% +46.02%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.142mb +0.00%  | 40.580ms +1.72%  | ±2.95% +67.79%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.434mb +0.00%  | 7.444ms -2.55%   | ±1.45% +31.12%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.993mb +0.00%  | 29.041ms -3.54%  | ±1.95% +86.03%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.993mb +0.00%  | 13.800μs -0.87%  | ±0.00% -100.00% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.993mb +0.00%  | 16.188μs -1.29%  | ±0.58% +0.00%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.812mb +0.00% | 191.585ms +0.76% | ±0.71% -19.76%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 398a749 into flow-php:1.x Aug 13, 2024
@stloyd stloyd deleted the bugfix/json-multi branch August 13, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants