Skip to content

Duplicate Module/Type enums in website to avoid dependencies and keep boundaries clean#1196

Merged
norberttech merged 2 commits intoflow-php:1.xfrom
norberttech:bug/dsl-modules-types-enums
Aug 16, 2024
Merged

Duplicate Module/Type enums in website to avoid dependencies and keep boundaries clean#1196
norberttech merged 2 commits intoflow-php:1.xfrom
norberttech:bug/dsl-modules-types-enums

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Duplicate Module/Type enums in website to avoid dependencies and keep boundaries clean

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.518mb +0.01%  | 510.775ms +0.04% | ±0.23% -20.85%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.585mb +0.01%  | 1.067s -0.50%    | ±0.65% -55.36%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 29.090mb +0.00% | 432.338ms +0.23% | ±0.45% +21.35%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.278mb +0.01%  | 33.880ms -1.71%  | ±0.17% -82.98%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.268mb +0.01%  | 755.647ms -0.41% | ±1.50% +296.43% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev        |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.554mb +0.00% | 60.078ms -0.95% | ±0.64% +5.01% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.714mb +0.00%  | 139.743ms +1.08% | ±0.79% +91.36% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.327mb +0.00%  | 118.967ms +0.78% | ±0.96% +91.59% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 124.379mb +0.00% | 1.231s -0.66%    | ±0.06% -92.89% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.469mb +0.00%  | 45.023ms +2.43%  | ±0.43% +79.03% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.200mb +0.00%  | 388.714ms +0.80% | ±0.42% +118.93%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.466mb +0.00%  | 79.773ms -5.07%  | ±0.44% -85.65%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.397mb +0.00% | 468.771ms +1.66% | ±0.20% -13.33%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.755mb +0.00%  | 236.388ms +0.27% | ±1.23% -61.14%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.593mb +0.00%  | 53.178ms +3.79%  | ±0.30% -53.12%   |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.310mb +0.00%  | 3.597ms +4.26%   | ±3.11% +501.02%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.914mb +0.00% | 188.317ms -2.32% | ±0.42% -72.99%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.634mb +0.00%  | 18.679ms -3.03%  | ±0.93% +7.71%    |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.550mb +0.00%  | 2.001ms +15.88%  | ±3.24% +194.68%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.550mb +0.00%  | 1.850ms +7.68%   | ±2.01% +2250.27% |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.662mb +0.00%  | 2.993ms +7.15%   | ±2.16% +34.00%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.191mb +0.00%  | 19.093ms +9.36%  | ±0.79% -62.71%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.191mb +0.00%  | 19.129ms +11.44% | ±0.85% -55.33%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 84.095mb +0.00%  | 1.700μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 84.095mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.445mb +0.00%  | 13.433ms +8.31%  | ±1.49% +7.45%    |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.816mb +0.00% | 62.250ms +2.49%  | ±0.79% +253.12%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.711mb +0.00%  | 1.723ms +12.88%  | ±1.81% +26.80%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 90.067mb +0.00%  | 61.942ms +6.30%  | ±0.84% +85.61%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.812mb +0.00%  | 4.661ms +8.84%   | ±1.79% -32.21%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.245mb +0.00%  | 40.019ms +1.09%  | ±1.70% +95.10%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.245mb +0.00%  | 39.736ms -0.82%  | ±0.64% -43.23%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.245mb +0.00%  | 39.634ms +0.33%  | ±0.95% -4.04%    |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.536mb +0.00%  | 7.420ms +0.73%   | ±0.62% -61.31%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 84.095mb +0.00%  | 28.795ms -1.86%  | ±1.15% +31.89%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 84.095mb +0.00%  | 13.836μs -0.76%  | ±2.02% -5.30%    |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 84.095mb +0.00%  | 16.806μs +7.00%  | ±0.28% -6.53%    |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.915mb +0.00% | 193.332ms -0.58% | ±0.15% -70.54%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit 5a5640a into flow-php:1.x Aug 16, 2024
@norberttech norberttech deleted the bug/dsl-modules-types-enums branch December 5, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant