Skip to content

Unify passing options to loaders/extractors through fluent interface#1208

Merged
norberttech merged 12 commits intoflow-php:1.xfrom
norberttech:1204-unify-passing-options-to-loadersextractors
Sep 5, 2024
Merged

Unify passing options to loaders/extractors through fluent interface#1208
norberttech merged 12 commits intoflow-php:1.xfrom
norberttech:1204-unify-passing-options-to-loadersextractors

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Unify passing options to loaders/extractors through fluent interface

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.513mb +0.45%  | 513.422ms +0.58% | ±0.13% -80.57%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.580mb +0.39%  | 1.065s +0.08%    | ±0.35% +106.24% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 29.085mb +0.07% | 431.789ms -1.26% | ±1.19% -25.44%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.273mb +0.41%  | 33.757ms +0.92%  | ±2.06% +496.12% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.263mb +0.41%  | 760.434ms -0.50% | ±2.06% +150.81% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.549mb +0.01% | 60.501ms +0.89% | ±1.37% +107.72% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.709mb +0.04%  | 141.002ms +0.29% | ±1.84% +123.66% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.322mb +0.02%  | 115.768ms -0.74% | ±0.31% -56.89%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 124.374mb +0.07% | 1.221s -0.45%    | ±0.36% +220.72% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.464mb +0.10%  | 44.123ms -0.10%  | ±0.59% -23.49%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.392mb +0.02% | 476.403ms +1.28% | ±0.62% +4.33%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.750mb +0.03%  | 236.831ms +2.43% | ±0.20% -61.26%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.588mb +0.12%  | 51.432ms +0.98%  | ±1.18% -8.19%    |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.305mb +0.02%  | 3.517ms +2.91%   | ±2.47% +89.19%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.909mb +0.02% | 188.767ms +0.12% | ±0.83% +45.00%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.629mb +0.02%  | 18.796ms +0.74%  | ±0.75% -33.67%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.545mb +0.02%  | 1.880ms +2.42%   | ±2.21% +7.58%    |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.545mb +0.02%  | 1.725ms -3.92%   | ±3.07% +122.25%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.657mb +0.02%  | 2.948ms +2.84%   | ±3.33% +315.00%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.186mb +0.02%  | 15.738ms -4.29%  | ±1.43% +4.85%    |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.186mb +0.02%  | 15.536ms -5.26%  | ±0.27% +188.96%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 84.090mb +0.02%  | 1.806μs +0.68%   | ±2.57% -3.64%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 84.090mb +0.02%  | 0.300μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.440mb +0.02%  | 12.652ms +1.60%  | ±1.16% -55.33%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.811mb +0.01% | 61.454ms +0.34%  | ±0.48% -10.82%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.706mb +0.02%  | 1.477ms -9.34%   | ±2.05% -40.08%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 90.062mb +0.02%  | 61.079ms -7.10%  | ±1.42% +159.94%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.807mb +0.02%  | 4.449ms +3.93%   | ±0.85% +54.75%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.240mb +0.02%  | 39.279ms +1.64%  | ±2.97% +789.45%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.240mb +0.02%  | 40.174ms +2.06%  | ±0.32% -55.67%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.240mb +0.02%  | 39.837ms +0.62%  | ±0.49% -67.88%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.531mb +0.02%  | 7.361ms -0.43%   | ±0.40% -55.67%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 84.090mb +0.02%  | 29.045ms +1.30%  | ±1.64% -3.28%    |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 84.090mb +0.02%  | 13.588μs +0.50%  | ±1.91% +106.36%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 84.090mb +0.02%  | 15.906μs -3.45%  | ±0.30% -90.18%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.910mb +0.02% | 195.831ms +1.40% | ±1.07% +67.90%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.195mb +0.03%  | 408.490ms +5.13% | ±3.21% +2203.92% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.461mb +0.13%  | 84.190ms +7.31%  | ±2.89% +152.13%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit 5fe9605 into flow-php:1.x Sep 5, 2024
@norberttech norberttech deleted the 1204-unify-passing-options-to-loadersextractors branch December 5, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant