Skip to content

Improved DX on adding path filter to file extractors#1235

Merged
norberttech merged 2 commits intoflow-php:1.xfrom
norberttech:feature/path-filtering-dx
Sep 26, 2024
Merged

Improved DX on adding path filter to file extractors#1235
norberttech merged 2 commits intoflow-php:1.xfrom
norberttech:feature/path-filtering-dx

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Improved DX on adding path filter to file extractors

Removed

Deprecated

Security


Description

@github-actions github-actions bot added size: S and removed size: XS labels Sep 26, 2024
@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.558mb +0.01%  | 513.401ms -1.24% | ±0.20% -68.25%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.672mb +0.01%  | 1.087s +1.20%    | ±0.25% -48.99%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 29.129mb +0.00% | 431.344ms -0.12% | ±1.32% +653.13% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.315mb +0.01%  | 33.201ms -2.92%  | ±0.36% -52.56%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.296mb +0.01%  | 675.331ms +1.35% | ±2.34% +93.01%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.591mb -0.00% | 61.309ms +2.56% | ±0.92% -36.07% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.756mb +0.00%  | 124.455ms +1.72% | ±1.89% +845.79% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.365mb +0.00%  | 99.996ms -0.67%  | ±1.31% +51.13%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 124.484mb +0.00% | 1.260s +2.31%    | ±0.55% -0.88%   |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.506mb +0.00%  | 29.172ms +2.09%  | ±0.71% +66.22%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.229mb -0.00%  | 393.124ms +1.11% | ±0.76% -17.26%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.495mb -0.00%  | 79.664ms -5.27%  | ±0.41% -84.81%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.426mb -0.00% | 474.622ms +1.45% | ±1.99% +2157.35% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.784mb -0.00%  | 237.578ms +0.75% | ±1.49% -4.48%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.622mb -0.00%  | 54.545ms +4.32%  | ±2.34% +16.01%   |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.405mb -0.00%  | 3.406ms +3.68%   | ±1.78% -2.18%    |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.943mb -0.00% | 189.619ms -1.11% | ±0.73% -55.89%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.663mb -0.00%  | 18.707ms -0.85%  | ±0.41% -55.66%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.645mb -0.00%  | 1.976ms +7.05%   | ±1.55% +89.33%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.645mb -0.00%  | 2.045ms +11.58%  | ±0.86% +33.64%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.757mb -0.00%  | 3.012ms +8.78%   | ±2.13% +78.19%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.286mb -0.00%  | 16.416ms +3.80%  | ±1.87% -26.77%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.286mb -0.00%  | 16.877ms +6.54%  | ±0.92% +5.59%    |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 84.190mb -0.00%  | 1.700μs -5.56%   | ±0.00% 0.00%     |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 84.190mb -0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.540mb -0.00%  | 13.429ms +5.73%  | ±1.13% -10.88%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.911mb -0.00% | 61.702ms -0.94%  | ±0.72% +335.05%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.806mb -0.00%  | 1.798ms +20.27%  | ±0.31% -84.24%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 90.096mb -0.00%  | 61.043ms -1.04%  | ±0.32% -61.83%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.907mb -0.00%  | 4.542ms -3.16%   | ±0.71% -66.97%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.274mb -0.00%  | 41.072ms -0.88%  | ±2.13% +49.38%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.274mb -0.00%  | 40.383ms +2.13%  | ±0.65% +283.06%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.274mb -0.00%  | 40.909ms +3.32%  | ±0.98% +237.95%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.631mb -0.00%  | 7.351ms +0.45%   | ±1.08% +46.61%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 84.190mb -0.00%  | 29.910ms +3.92%  | ±1.01% -37.06%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 84.190mb -0.00%  | 13.679μs -0.45%  | ±0.91% -50.36%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 84.190mb -0.00%  | 16.099μs +0.52%  | ±1.52% -50.07%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.944mb -0.00% | 191.902ms -0.45% | ±0.55% -62.75%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit 926b66e into flow-php:1.x Sep 26, 2024
@norberttech norberttech deleted the feature/path-filtering-dx branch December 5, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant