Skip to content

Fixed scenario where list is optional column but list element is required and value is empty list#1263

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/parquet-optional-list-required-element
Dec 5, 2024
Merged

Fixed scenario where list is optional column but list element is required and value is empty list#1263
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/parquet-optional-list-required-element

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • Parquet - optional list required element - list empty
  • Parquet - optional map required value - map empty

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.640mb +0.01%   | 514.416ms -0.06% | ±0.91% -60.28%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.736mb +0.01%   | 1.094s -0.14%    | ±1.28% -45.61%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 102.369mb +0.00% | 947.046ms -1.21% | ±1.33% +82.72%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.368mb +0.01%   | 34.151ms +0.45%  | ±2.81% +152.24% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.349mb +0.01%   | 657.750ms +0.51% | ±0.57% -48.20%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.643mb +0.00% | 63.045ms +3.45% | ±2.43% +48.20% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.837mb +0.00%  | 143.722ms +2.38% | ±0.43% +186.60% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.471mb +0.00%  | 116.289ms +0.17% | ±0.56% -67.42%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 255.240mb +0.00% | 22.089s +2.93%   | ±1.23% +619.37% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.559mb +0.00%  | 44.415ms +0.14%  | ±1.03% +163.03% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.392mb +0.00%  | 3.845ms +16.48%  | ±1.92% -41.57%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.995mb +0.00% | 188.324ms +1.79% | ±1.32% +224.49% |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.715mb +0.00%  | 19.032ms -0.25%  | ±1.15% -22.90%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.632mb +0.00%  | 2.148ms +10.41%  | ±2.85% +26.07%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.632mb +0.00%  | 2.070ms +6.91%   | ±2.22% -30.71%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.744mb +0.00%  | 2.967ms +0.41%   | ±0.56% +97.44%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.273mb +0.00%  | 19.247ms +10.40% | ±2.45% +101.67% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.273mb +0.00%  | 18.862ms +6.52%  | ±1.01% -67.04%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 84.176mb +0.00%  | 1.694μs -5.89%   | ±2.83% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 84.176mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.527mb +0.00%  | 12.584ms -0.38%  | ±1.29% +60.84%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.897mb +0.00% | 63.900ms -2.47%  | ±1.12% -17.84%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.792mb +0.00%  | 1.681ms +7.27%   | ±2.11% -40.89%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 90.144mb +0.00%  | 66.266ms +2.11%  | ±0.80% -57.10%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.894mb +0.00%  | 4.272ms -1.30%   | ±0.75% -30.65%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.326mb +0.00%  | 41.135ms +5.20%  | ±2.65% +219.84% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.326mb +0.00%  | 40.785ms +4.21%  | ±0.38% -69.64%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.326mb +0.00%  | 40.563ms +2.14%  | ±0.51% -38.06%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.618mb +0.00%  | 7.548ms +1.47%   | ±1.45% +39.15%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 84.176mb +0.00%  | 29.052ms -0.45%  | ±1.79% +171.53% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 84.176mb +0.00%  | 13.418μs +0.70%  | ±1.05% -25.37%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 84.176mb +0.00%  | 15.993μs -0.66%  | ±1.91% +0.00%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.996mb +0.00% | 190.373ms +0.20% | ±0.34% -85.34%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.218mb +0.00%  | 395.739ms +1.01% | ±0.99% -35.99%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.484mb +0.00%  | 81.322ms +1.06%  | ±0.80% -0.79%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.480mb +0.00% | 478.594ms -0.21% | ±0.56% +265.14% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.838mb +0.00%  | 239.037ms -1.43% | ±3.01% +213.46% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.676mb +0.00%  | 52.274ms +1.85%  | ±2.11% -14.25%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit c64591c into flow-php:1.x Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant