Skip to content

Fixed pivot edge case when pivot column is null#1269

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/pivot-null-edge-case
Dec 9, 2024
Merged

Fixed pivot edge case when pivot column is null#1269
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/pivot-null-edge-case

Conversation

@norberttech
Copy link
Member

@norberttech norberttech commented Dec 9, 2024

Change Log

Added

Fixed

  • pivot edge case when pivot column is null

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.644mb +0.01%   | 514.424ms +0.53% | ±0.23% +47.22%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.742mb +0.01%   | 1.098s +0.59%    | ±0.85% +99.54%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 102.377mb +0.00% | 972.872ms +4.31% | ±0.95% +464.75% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.371mb +0.01%   | 33.404ms -0.06%  | ±0.89% +41.78%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.352mb +0.01%   | 672.557ms +0.83% | ±1.01% +231.97% |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.647mb +0.00% | 62.679ms +4.65% | ±2.05% +55.49% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.841mb +0.00%  | 138.668ms -0.24% | ±0.95% -9.04%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.477mb +0.00%  | 116.521ms -1.20% | ±0.35% -58.40% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 255.247mb +0.00% | 21.636s -0.51%   | ±0.42% -26.81% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.562mb +0.00%  | 44.479ms -1.18%  | ±0.69% +64.74% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.396mb +0.00%  | 3.862ms +14.02%  | ±0.93% -72.03%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 103.000mb +0.00% | 189.875ms +0.95% | ±1.09% +46.31%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.720mb +0.00%  | 19.180ms +2.31%  | ±0.75% -16.48%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.636mb +0.00%  | 2.200ms +15.20%  | ±1.63% +144.88% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.636mb +0.00%  | 2.320ms +24.25%  | ±0.83% -14.11%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.748mb +0.00%  | 3.068ms +6.75%   | ±1.74% +17.33%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.277mb +0.00%  | 15.597ms +4.60%  | ±1.27% -39.58%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.277mb +0.00%  | 15.942ms +7.27%  | ±1.13% -13.74%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 84.180mb +0.00%  | 1.900μs +5.91%   | ±0.00% -100.00% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 84.180mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.531mb +0.00%  | 13.197ms +6.18%  | ±3.51% +205.38% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.901mb +0.00% | 63.898ms -2.91%  | ±1.40% -13.38%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.796mb +0.00%  | 1.800ms +24.02%  | ±1.18% -10.99%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 90.149mb +0.00%  | 67.421ms +4.12%  | ±1.72% +171.89% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.898mb +0.00%  | 4.729ms +10.82%  | ±1.79% -0.74%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.330mb +0.00%  | 41.294ms +5.14%  | ±1.00% -45.40%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.331mb +0.00%  | 41.280ms +3.92%  | ±1.12% -18.92%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.330mb +0.00%  | 41.248ms +2.88%  | ±1.29% +17.57%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.622mb +0.00%  | 8.023ms +7.76%   | ±3.72% +425.43% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 84.180mb +0.00%  | 29.605ms +2.35%  | ±1.16% -1.50%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 84.180mb +0.00%  | 13.941μs +2.26%  | ±1.80% +19.06%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 84.180mb +0.00%  | 16.242μs -0.73%  | ±2.01% -13.79%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 103.001mb +0.00% | 194.806ms +1.84% | ±0.64% -2.20%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.220mb +0.00%  | 404.494ms +0.19% | ±1.53% +15.27%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.486mb +0.00%  | 80.015ms +0.47%  | ±1.87% +424.21% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.486mb +0.00% | 481.738ms +2.32% | ±2.48% +43.50%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.844mb +0.00%  | 246.516ms +3.41% | ±0.95% -58.00%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.682mb +0.00%  | 53.299ms +4.81%  | ±0.25% -71.69%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 0162522 into flow-php:1.x Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant