Skip to content

Fixed schema inferring when first rows are null#1274

Merged
norberttech merged 4 commits intoflow-php:1.xfrom
norberttech:bug/schema-infer
Dec 18, 2024
Merged

Fixed schema inferring when first rows are null#1274
norberttech merged 4 commits intoflow-php:1.xfrom
norberttech:bug/schema-infer

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • Fixed schema inferring when first rows are null

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.700mb +0.15%   | 514.353ms +0.15% | ±0.24% -61.44%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.803mb +0.15%   | 1.091s -0.70%    | ±1.26% +173.90% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 102.512mb +0.02% | 966.259ms +2.11% | ±0.69% -24.29%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.429mb +0.16%   | 33.125ms +0.59%  | ±0.33% -64.40%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.410mb +0.07%   | 669.177ms +1.01% | ±1.44% -4.01%   |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.705mb +0.75% | 63.239ms +6.90% | ±1.42% -12.79% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.896mb +1.47%  | 112.743ms +3.36% | ±0.90% +146.71% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.423mb +0.54%  | 103.694ms -0.58% | ±1.08% +161.86% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 255.381mb +0.13% | 21.553s -0.58%   | ±0.10% -90.99%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.618mb +0.95%  | 44.332ms -0.42%  | ±0.27% -65.95%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.518mb +1.01%  | 3.173ms -13.28%  | ±1.76% -25.49%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 103.055mb +0.86% | 203.631ms +6.75% | ±1.09% +316.90% |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.775mb +1.03%  | 19.769ms +2.58%  | ±1.73% +108.11% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.758mb +1.00%  | 1.637ms -11.59%  | ±2.37% +18.48%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.758mb +1.00%  | 1.582ms -13.12%  | ±1.36% -55.22%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.870mb +1.03%  | 2.612ms -8.21%   | ±0.97% -60.27%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.399mb +1.03%  | 14.599ms -8.93%  | ±1.05% -35.19%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.399mb +1.03%  | 14.544ms -10.09% | ±1.04% -34.17%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 84.303mb +1.05%  | 1.694μs -5.57%   | ±2.83% +6.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 84.303mb +1.05%  | 0.200μs -33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.653mb +1.12%  | 12.602ms +1.58%  | ±0.59% -81.30%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 123.024mb +0.72% | 62.705ms +2.95%  | ±2.70% +235.64% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.918mb +1.02%  | 1.281ms -14.04%  | ±3.45% +17.46%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 90.208mb +0.98%  | 58.838ms -4.49%  | ±1.84% +54.74%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 89.020mb +1.00%  | 3.995ms -8.90%   | ±2.33% +85.52%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.386mb +1.05%  | 46.493ms +19.04% | ±1.59% +21.05%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.387mb +1.05%  | 39.571ms -0.51%  | ±1.05% +60.26%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.386mb +1.05%  | 42.415ms +6.51%  | ±0.41% -19.32%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.744mb +1.02%  | 7.349ms +0.06%   | ±1.22% -38.62%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 84.303mb +1.05%  | 28.867ms +1.24%  | ±0.37% -67.78%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 84.303mb +1.05%  | 13.480μs -2.36%  | ±1.25% +267.64% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 84.303mb +1.05%  | 16.121μs +1.60%  | ±0.78% -39.81%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 103.057mb +0.86% | 196.915ms -0.02% | ±0.22% -76.51%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.305mb +0.01%  | 392.352ms -0.13% | ±0.95% -55.45%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.571mb +0.02%  | 80.683ms -0.09%  | ±0.78% +8.55%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.543mb +0.45% | 489.784ms +1.90% | ±1.04% +86.13%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.901mb +0.44%  | 244.478ms +1.50% | ±2.29% +169.82% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.739mb +0.37%  | 52.720ms -0.09%  | ±1.32% -42.41%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit e35478a into flow-php:1.x Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant