Merged
Conversation
stloyd
reviewed
Oct 12, 2023
stloyd
approved these changes
Oct 12, 2023
Contributor
|
@norberttech why not host the docker images right here on GH? to pull it, instead of here how to automate publishing the images to GHCR using GHA: https://github.com/flavioheleno/watchr/blob/main/.github/workflows/release.yml#L68-L91 |
Member
Author
|
Honestly, I didn't think about it 🤦♂️ Yeah, I think we can start from here and if docker finally grants us open-source team license we can also publish to hub |
norberttech
force-pushed
the
feature/dockerfile
branch
from
b30c3f7 to
1e7c79b
Compare
Member
Author
|
Ok, I think I managed to make it work. Instead of fetching phar from github the Dockerfile will just grab the latest phar. I tested it on my fork, everything worked just as expected. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
Refs: #511
Additionally, I applied for an opensource organization through dockerhub, once (if) we get it I will prepare GitHub actions that will build the image and push it after merge/release to dockerhub.