Entry factory moved from extractors to FlowContext#616
Merged
stloyd merged 1 commit intoflow-php:1.xfrom Oct 20, 2023
Merged
Conversation
norberttech
requested changes
Oct 20, 2023
stloyd
force-pushed
the
feature/entry-factory-context
branch
from
77e69a0 to
bb9d434
Compare
norberttech
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
To improve code quality and reduce code coupling
EntryFactorywas removed from all constructors of extractors, in favor of passing it intoFlowContext& re-using same entry factory in a whole pipeline.