Skip to content

Replaced codename parquet with flow parquet library in parquet adapter#694

Merged
norberttech merged 2 commits intoflow-php:1.xfrom
norberttech:feature/parquet-loader-replace-lib
Oct 31, 2023
Merged

Replaced codename parquet with flow parquet library in parquet adapter#694
norberttech merged 2 commits intoflow-php:1.xfrom
norberttech:feature/parquet-loader-replace-lib

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Replaced codename parquet with flow parquet library in parquet adapter

Removed

  • Codename Parquet library dependency

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev           |
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 44.121mb -0.07%  | 607.492ms +17.33% | ±2.42% +116.13%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 14.005mb -0.23%  | 494.823ms +17.35% | ±1.80% +2794.41% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 18.667mb -0.17%  | 909.874ms +6.56%  | ±1.60% +206.19%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 237.768mb -0.01% | 1.356s +15.07%    | ±0.07% -91.59%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 7.275mb -0.44%   | 26.018ms +17.49%  | ±3.85% +496.74%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 7.622mb -0.42%   | 830.091ms +11.57% | ±1.79% +656.81%  |
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.061mb -0.04% | 92.470ms +15.30% | ±2.42% +175.83% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+------------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev           |
+--------------------+----------------+------+-----+------------------+-------------------+------------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 93.223mb -0.03%  | 950.805ms +12.91% | ±2.60% +33.33%   |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 47.139mb -0.07%  | 94.343ms +12.74%  | ±2.04% +105.11%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 88.573mb -0.04%  | 95.513ms +5.73%   | ±0.22% -52.36%   |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 281.205mb +0.15% | 2.268s +95.70%    | ±1.50% +3309.23% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.560mb -0.20%  | 47.820ms +10.87%  | ±1.69% +90.04%   |
+--------------------+----------------+------+-----+------------------+-------------------+------------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-------------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev            |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.685mb -0.05% | 5.786ms +1.06%    | ±0.71% -58.83%    |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.476mb -0.04% | 234.117ms +9.16%  | ±0.70% -36.18%    |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 59.001mb -0.05% | 22.561ms +4.86%   | ±0.94% +43.72%    |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.824mb -0.05% | 3.777ms -3.28%    | ±2.44% +321.17%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.824mb -0.05% | 3.855ms +3.01%    | ±1.62% +59.89%    |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.037mb -0.05% | 4.972ms +3.37%    | ±1.82% +100.76%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.566mb -0.05% | 26.593ms -4.66%   | ±2.76% +252.03%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.566mb -0.05% | 25.417ms -8.36%   | ±0.86% +69.74%    |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.637mb -0.06% | 2.394μs -14.13%   | ±1.99% -42.25%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.637mb -0.06% | 0.500μs 0.00%     | ±0.00% 0.00%      |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.871mb -0.05% | 18.515ms +7.66%   | ±2.61% +332.42%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.390mb -0.04% | 84.756ms +16.57%  | ±1.42% +316.19%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.087mb -0.05% | 4.096ms -1.26%    | ±2.99% +93.97%    |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.355mb -0.05% | 57.680ms +4.52%   | ±3.84% +500.38%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.187mb -0.05% | 10.335ms +3.03%   | ±3.02% +25.47%    |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.637mb -0.06% | 66.994ms +8.61%   | ±2.40% +596.48%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.637mb -0.06% | 65.895ms +6.40%   | ±1.07% +170.51%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.637mb -0.06% | 66.168ms +6.05%   | ±2.57% +462.38%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.912mb -0.05% | 12.236ms +7.91%   | ±1.47% +101.93%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.637mb -0.06% | 49.465ms +6.62%   | ±3.08% +470.67%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.637mb -0.06% | 30.981μs +19.21%  | ±1.83% +81.81%    |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.637mb -0.06% | 41.890μs +30.66%  | ±2.82% +215.65%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.476mb -0.04% | 234.863ms +9.88%  | ±0.51% +25.81%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 91.758mb -0.04% | 206.467ms +18.57% | ±1.65% +16935.10% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 47.619mb -0.04% | 99.756ms +11.33%  | ±2.75% +366.77%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.418mb -0.26% | 25.407ms +17.15%  | ±3.12% +788.58%   |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-------------------+

@norberttech norberttech merged commit de200cc into flow-php:1.x Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants