Skip to content

Prevent uninitialized string check in NativeEntryFactory#743

Merged
stloyd merged 1 commit intoflow-php:1.xfrom
stloyd:bugfix/742-skip
Nov 6, 2023
Merged

Prevent uninitialized string check in NativeEntryFactory#743
stloyd merged 1 commit intoflow-php:1.xfrom
stloyd:bugfix/742-skip

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 6, 2023

Change Log

Added

Fixed

  • Prevent uninitialized string check in `NativeEntryFactory`

Changed

Removed

Deprecated

Security


Description

Closes #742

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev           |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.139mb -0.00%  | 357.497ms -0.12% | ±0.52% -6.16%    |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.789mb +0.00%   | 270.044ms -1.06% | ±2.36% +35.71%   |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.937mb +0.00%   | 579.891ms +0.90% | ±3.36% +2013.33% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 233.514mb +0.00% | 781.596ms +0.08% | ±0.41% -16.13%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.783mb +0.00%   | 19.171ms -0.67%  | ±0.88% -21.99%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.783mb +0.00%   | 401.105ms -0.25% | ±0.66% +112.38%  |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+-----------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.049mb +0.00% | 48.930ms +0.46% | ±0.85% +494.97% |
+-----------------------------+--------------------------+------+-----+-----------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 93.289mb +0.00%  | 571.088ms +1.22% | ±0.13% -69.75%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.066mb +0.00%  | 67.998ms -0.79%  | ±0.86% -5.29%   |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 88.568mb +0.00%  | 61.836ms -0.35%  | ±0.90% -2.93%   |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 284.027mb +0.00% | 1.188s +0.98%    | ±1.39% +383.34% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.559mb +0.00%  | 41.271ms +1.40%  | ±0.61% +47.51%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+-----------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.659mb +0.00% | 2.431ms +4.47%   | ±0.61% -66.70%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.451mb +0.00% | 152.110ms +0.90% | ±0.98% +183.37%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 58.977mb +0.00% | 15.328ms +1.84%  | ±0.28% +13.30%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.797mb +0.00% | 2.068ms +9.78%   | ±2.33% +250.66%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.797mb +0.00% | 1.840ms +8.85%   | ±2.23% +83.61%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.011mb +0.00% | 2.838ms +7.85%   | ±3.84% +971.66%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.540mb +0.00% | 14.661ms -2.48%  | ±0.80% -62.78%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.539mb +0.00% | 14.666ms -2.23%  | ±1.01% -62.25%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.610mb +0.00% | 1.800μs -0.34%   | ±0.00% -100.00%  |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.610mb +0.00% | 0.300μs -25.00%  | ±0.00% -100.00%  |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.844mb +0.00% | 10.512ms +2.10%  | ±1.37% +94.83%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.364mb +0.00% | 49.057ms +4.60%  | ±0.71% -40.94%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.060mb +0.00% | 2.115ms +13.65%  | ±2.66% +83.75%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.330mb +0.00% | 35.584ms +5.58%  | ±0.69% +5.58%    |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.161mb +0.00% | 4.989ms +3.74%   | ±0.81% -68.39%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.610mb +0.00% | 38.174ms +4.48%  | ±1.05% +50.58%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.610mb +0.00% | 38.273ms +3.60%  | ±0.84% +78.37%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.610mb +0.00% | 38.878ms +5.66%  | ±2.69% +271.48%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.885mb +0.00% | 7.870ms +8.75%   | ±1.63% -47.65%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.610mb +0.00% | 31.805ms +12.60% | ±2.00% +2400.98% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.610mb +0.00% | 13.288μs +1.95%  | ±0.71% -55.04%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.610mb +0.00% | 16.122μs +4.69%  | ±3.31% +523.97%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.451mb +0.00% | 163.721ms +3.56% | ±0.68% +4.45%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 91.706mb +0.03% | 117.681ms +0.45% | ±1.10% -66.25%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 47.595mb +0.01% | 59.814ms +5.17%  | ±1.27% +430.45%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.392mb -0.00% | 14.100ms +2.33%  | ±1.97% +5.74%    |
+-------------------------+----------------------------+------+-----+-----------------+------------------+------------------+

@stloyd stloyd merged commit 1052bff into flow-php:1.x Nov 6, 2023
@stloyd stloyd deleted the bugfix/742-skip branch November 6, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entry string value with space char

2 participants