Skip to content

Make types implementation serializable, mark native types as nullable#777

Merged
stloyd merged 1 commit intoflow-php:1.xfrom
stloyd:feature/types-serializable
Nov 10, 2023
Merged

Make types implementation serializable, mark native types as nullable#777
stloyd merged 1 commit intoflow-php:1.xfrom
stloyd:feature/types-serializable

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 10, 2023

Change Log

Added

Fixed

Changed

  • Make types implementation serializable, mark native types as nullable

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev          |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.272mb -0.00%  | 439.947ms -17.67% | ±0.29% -54.17%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.837mb +0.01%   | 341.647ms -19.26% | ±0.26% +27.51%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.005mb +0.05%   | 657.721ms -22.52% | ±0.53% +236.51% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 233.594mb +0.00% | 942.256ms -19.46% | ±0.18% -1.09%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.831mb +0.01%   | 24.893ms -8.23%   | ±0.16% -93.01%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.831mb +0.01%   | 532.388ms -21.11% | ±1.19% +291.11% |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.098mb +0.00% | 62.168ms -31.12% | ±0.32% -71.71% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev          |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.279mb +0.00%  | 666.995ms -18.93% | ±0.15% -79.18%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.114mb +0.00%  | 69.799ms -15.05%  | ±0.87% +103.55% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.556mb +0.00%  | 68.906ms -25.03%  | ±1.96% +327.51% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 286.027mb +0.00% | 1.565s -23.60%    | ±0.40% -37.03%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.608mb +0.00%  | 35.947ms -15.18%  | ±1.44% +217.46% |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev          |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.707mb +0.00% | 3.223ms -39.39%   | ±0.85% -69.98%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.499mb +0.00% | 176.171ms -17.08% | ±0.02% -96.93%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 59.025mb +0.00% | 17.855ms -18.42%  | ±0.32% -18.15%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.846mb +0.00% | 2.719ms -28.21%   | ±1.72% -19.28%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.846mb +0.00% | 2.819ms -23.12%   | ±1.34% -58.51%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.059mb +0.00% | 3.683ms -24.97%   | ±1.79% -29.99%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.588mb +0.00% | 17.604ms -34.95%  | ±0.15% -80.37%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.588mb +0.00% | 17.624ms -35.41%  | ±0.57% +78.55%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.659mb +0.00% | 2.200μs -18.34%   | ±3.71% +109.95% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.659mb +0.00% | 0.500μs 0.00%     | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.892mb +0.00% | 13.745ms -18.05%  | ±2.70% +168.87% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.412mb +0.00% | 57.748ms -21.62%  | ±1.85% +119.86% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.109mb +0.00% | 2.857ms -34.33%   | ±1.13% -58.49%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.379mb +0.00% | 41.660ms -28.81%  | ±0.67% -10.09%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.209mb +0.00% | 6.740ms -31.32%   | ±0.81% -62.33%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.659mb +0.00% | 45.775ms -26.33%  | ±0.16% -90.28%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.659mb +0.00% | 48.685ms -21.69%  | ±0.13% -71.20%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.659mb +0.00% | 46.342ms -26.01%  | ±0.24% -26.41%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.933mb +0.00% | 9.758ms -14.34%   | ±1.51% +47.45%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.658mb +0.00% | 36.005ms -21.19%  | ±0.17% -73.95%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.659mb +0.00% | 21.299μs -17.18%  | ±2.30% -29.31%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.659mb +0.00% | 26.179μs -18.21%  | ±0.48% -81.79%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.500mb +0.00% | 176.408ms -18.78% | ±0.16% -72.23%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 93.713mb +0.02% | 149.326ms -19.32% | ±0.38% +63.80%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 48.628mb +0.01% | 76.632ms -18.95%  | ±0.16% -74.81%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.651mb -0.01% | 18.268ms -23.93%  | ±0.31% -88.78%  |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+

@stloyd stloyd merged commit d2f1ec6 into flow-php:1.x Nov 10, 2023
@stloyd stloyd deleted the feature/types-serializable branch November 10, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants