Skip to content

Changed default value for format in toDate scalar function#809

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/to-date-default-format
Nov 20, 2023
Merged

Changed default value for format in toDate scalar function#809
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/to-date-default-format

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Changed default value for format in toDate scalar function

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.747mb +0.00%  | 1.149s +1.13%    | ±0.22% -59.51%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.605mb +0.01%   | 304.193ms +0.61% | ±0.27% +88.31%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.771mb +0.01%   | 1.398s +0.85%    | ±1.22% +51.99%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.480mb +0.00% | 1.570s -0.32%    | ±0.87% +110.73% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.559mb +0.01%   | 24.212ms -2.42%  | ±1.43% -10.62%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.560mb +0.01%   | 407.058ms +1.37% | ±1.13% -36.15%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.246mb +0.00% | 63.108ms -3.83% | ±0.38% -63.00% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.727mb +0.00%  | 443.825ms -0.53% | ±0.76% +1.22%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.711mb +0.00%  | 70.510ms +1.49%  | ±0.05% -97.63% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.309mb +0.00% | 54.011ms -1.64%  | ±0.44% -79.19% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.787mb +0.00% | 1.485s +0.95%    | ±0.29% -20.29% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.589mb +0.00%  | 41.236ms -2.37%  | ±0.42% +82.59% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.293mb +0.00%  | 2.575ms +18.51%  | ±0.80% -27.06%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.084mb +0.00%  | 177.248ms -2.23% | ±0.52% -37.01%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.609mb +0.00%  | 17.854ms -0.53%  | ±0.55% +56.88%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 75.432mb +0.00%  | 1.743ms +4.65%   | ±1.81% +178.38% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 75.432mb +0.00%  | 1.727ms +2.14%   | ±3.06% +86.69%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.645mb +0.00%  | 2.820ms +7.12%   | ±1.07% -59.97%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.174mb +0.00%  | 14.584ms +3.28%  | ±0.47% +91.84%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.174mb +0.00%  | 14.426ms +1.01%  | ±1.02% +133.12% |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.077mb +0.00%  | 1.706μs -4.90%   | ±2.72% +1.92%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.077mb +0.00%  | 0.300μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.634mb +0.00%  | 13.418ms +2.95%  | ±3.35% +99.93%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 115.993mb +0.00% | 64.043ms -0.04%  | ±1.63% +34.49%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.695mb +0.00%  | 1.849ms -0.93%   | ±2.45% +38.42%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.962mb +0.00%  | 32.892ms +1.07%  | ±0.45% -42.01%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.795mb +0.00%  | 4.505ms -3.92%   | ±3.47% +8.27%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.220mb +0.00%  | 38.369ms -0.14%  | ±1.94% +262.93% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.221mb +0.00%  | 38.269ms -0.93%  | ±0.24% -69.99%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.220mb +0.00%  | 38.750ms -0.02%  | ±1.92% +978.67% |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.519mb +0.00%  | 7.308ms -1.18%   | ±1.08% +57.43%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.077mb +0.00%  | 29.187ms +2.33%  | ±1.11% +138.47% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.077mb +0.00%  | 12.758μs -0.43%  | ±2.28% +211.44% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.077mb +0.00%  | 15.483μs -2.04%  | ±1.38% +365.11% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.085mb +0.00%  | 182.075ms -1.32% | ±0.71% +111.97% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 98.214mb +0.00%  | 965.325ms +0.44% | ±0.91% +85.57%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 21.905mb +0.00%  | 189.083ms -0.32% | ±0.23% -72.20%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.837mb +0.00% | 768.091ms +0.54% | ±1.74% +164.33% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.555mb +0.00%  | 386.335ms -0.29% | ±0.15% -83.93%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.678mb +0.00%  | 79.250ms +1.12%  | ±0.21% -80.57%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 6ead603 into flow-php:1.x Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant