Skip to content

Fix wrong return type on entry reference DSL functions#814

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
stloyd:chore/dsl-ref
Nov 21, 2023
Merged

Fix wrong return type on entry reference DSL functions#814
norberttech merged 1 commit intoflow-php:1.xfrom
stloyd:chore/dsl-ref

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 21, 2023

Change Log

Added

Fixed

  • Fix wrong return type on entry reference DSL functions

Changed

Removed

Deprecated

Security


Description

Before:
Zrzut ekranu 2023-11-21 o 17 14 44
After:
Zrzut ekranu 2023-11-21 o 17 15 50

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.743mb +0.00%  | 706.745ms +1.49% | ±0.34% -65.87%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.603mb +0.00%   | 293.913ms -0.51% | ±0.10% -73.33%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.767mb +0.00%   | 939.468ms +0.01% | ±0.08% -87.89%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.477mb +0.00% | 1.119s +0.69%    | ±0.34% -68.38%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.560mb +0.00%   | 23.040ms -1.33%  | ±2.20% +119.15% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.560mb +0.00%   | 409.575ms +1.53% | ±3.34% +451.23% |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.244mb +0.00% | 63.486ms +1.02% | ±1.94% -22.84% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.404mb +0.00%  | 444.132ms +0.98% | ±0.29% -74.38%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.709mb +0.00%  | 71.694ms -1.44%  | ±1.96% +298.37% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 104.986mb +0.00% | 55.779ms -0.24%  | ±1.10% +71.94%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.464mb +0.00% | 1.463s -1.00%    | ±0.19% -84.95%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.587mb +0.00%  | 41.694ms -1.44%  | ±0.09% -83.32%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.291mb +0.00%  | 2.253ms +4.42%   | ±3.31% +276.49%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.082mb +0.00%  | 178.574ms -0.68% | ±0.95% +25.68%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.608mb +0.00%  | 18.045ms -0.45%  | ±1.74% +56.80%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 75.430mb +0.00%  | 1.630ms -4.39%   | ±1.26% +110.93%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 75.430mb +0.00%  | 1.668ms +1.16%   | ±2.09% +80.32%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.643mb +0.00%  | 2.723ms +6.07%   | ±2.56% +11.94%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.172mb +0.00%  | 14.669ms +3.41%  | ±0.55% +7.33%    |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.172mb +0.00%  | 14.665ms +1.53%  | ±1.42% +82.22%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.075mb +0.00%  | 1.800μs +5.51%   | ±0.00% -100.00%  |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.075mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.632mb +0.00%  | 13.051ms +6.33%  | ±2.33% +3687.54% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 115.991mb +0.00% | 62.478ms -2.74%  | ±2.29% +97.51%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.693mb +0.00%  | 2.105ms +13.64%  | ±0.84% -33.16%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.961mb +0.00%  | 35.876ms +3.19%  | ±0.60% +45.49%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.793mb +0.00%  | 5.043ms +15.35%  | ±2.51% +594.13%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.218mb +0.00%  | 38.436ms -0.20%  | ±0.27% -50.81%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.219mb +0.00%  | 39.044ms +2.11%  | ±0.21% -72.00%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.218mb +0.00%  | 38.719ms +1.85%  | ±0.98% -1.82%    |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.517mb +0.00%  | 7.385ms -0.05%   | ±2.19% +41.71%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.075mb +0.00%  | 28.577ms +0.89%  | ±1.24% -50.89%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.075mb +0.00%  | 12.760μs -0.32%  | ±2.63% +106.02%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.075mb +0.00%  | 15.436μs -0.37%  | ±1.81% +494.87%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.083mb +0.00%  | 183.787ms -0.18% | ±1.02% -14.01%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.171mb +0.00%  | 354.047ms +0.48% | ±0.38% -26.80%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.094mb +0.00%  | 70.991ms +0.56%  | ±1.56% +84.35%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.835mb +0.00% | 394.204ms +0.10% | ±1.63% -2.04%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.553mb +0.00%  | 200.652ms +1.62% | ±0.63% +20.28%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.675mb +0.00%  | 42.296ms -4.01%  | ±0.66% -79.13%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit 73dad59 into flow-php:1.x Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants