Skip to content

Fixed some warnings in parquet library#817

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/warnings
Nov 21, 2023
Merged

Fixed some warnings in parquet library#817
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/warnings

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • Fixed some warnings in parquet library

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.757mb +0.00%  | 677.158ms -0.71% | ±2.85% +301.81% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.621mb +0.01%   | 297.474ms +0.97% | ±0.36% +117.20% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.781mb +0.01%   | 923.206ms +0.39% | ±0.30% -77.21%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.490mb +0.00% | 1.138s +4.09%    | ±2.28% +199.99% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.560mb +0.01%   | 24.122ms +2.61%  | ±1.88% -7.55%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.560mb +0.01%   | 406.939ms -0.07% | ±0.61% +72.16%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.246mb +0.00% | 61.022ms -0.47% | ±0.95% -61.30% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.417mb +0.00%  | 436.962ms -0.92% | ±2.12% +23.72% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.727mb +0.00%  | 72.184ms +1.64%  | ±0.29% -68.63% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 104.999mb +0.00% | 55.201ms -1.66%  | ±1.06% +31.72% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.477mb +0.00% | 1.444s -3.85%    | ±0.32% -64.24% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.601mb +0.00%  | 41.487ms -0.01%  | ±0.40% +6.45%  |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.300mb +0.00%  | 2.616ms -12.81%  | ±1.21% -15.03%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.091mb +0.00%  | 177.310ms +0.55% | ±0.48% +893.99% |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.617mb +0.00%  | 17.524ms -2.11%  | ±2.74% +216.56% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.540mb +0.00%  | 1.654ms -19.11%  | ±0.24% -91.24%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.540mb +0.00%  | 1.652ms -17.14%  | ±1.78% -11.36%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.652mb +0.00%  | 2.515ms -13.30%  | ±1.39% -57.19%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.181mb +0.00%  | 14.293ms -3.48%  | ±0.49% -48.97%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.181mb +0.00%  | 14.186ms -2.24%  | ±0.83% +25.05%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.084mb +0.00%  | 1.794μs -10.30%  | ±2.67% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.084mb +0.00%  | 0.200μs -50.00%  | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.641mb +0.00%  | 12.158ms -6.59%  | ±2.03% +265.39% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.001mb +0.00% | 61.562ms -4.04%  | ±0.21% -78.07%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.702mb +0.00%  | 1.833ms -12.68%  | ±1.38% -56.90%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.968mb +0.00%  | 34.054ms -2.45%  | ±0.98% +269.43% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.802mb +0.00%  | 3.903ms -10.34%  | ±0.79% -71.85%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.227mb +0.00%  | 38.763ms -1.94%  | ±0.46% +38.63%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.228mb +0.00%  | 38.539ms -1.95%  | ±0.69% -24.28%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.227mb +0.00%  | 38.857ms -1.70%  | ±0.27% +439.29% |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.527mb +0.00%  | 7.334ms -2.16%   | ±0.59% -53.95%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.084mb +0.00%  | 28.438ms -0.78%  | ±0.77% +82.56%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.084mb +0.00%  | 13.288μs -1.48%  | ±0.71% +1.51%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.084mb +0.00%  | 15.918μs -4.68%  | ±0.88% -74.16%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.092mb +0.00%  | 179.864ms +0.00% | ±0.09% -93.99%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.173mb +0.00%  | 325.038ms -2.61% | ±2.00% +51.01%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.096mb +0.00%  | 64.751ms -1.68%  | ±0.82% -17.79%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.843mb +0.00% | 373.148ms -0.21% | ±0.33% -33.45%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.561mb +0.00%  | 189.403ms +1.29% | ±0.89% +46.06%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.686mb +0.00%  | 39.445ms -2.37%  | ±0.77% +47.68%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 8f560a1 into flow-php:1.x Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant