Simplify ScalarType::isValid() method

[stloyd]

Change Log

Added

Fixed

Changed

• Simplify `ScalarType::isValid()` method

Removed

Deprecated

Security

---

Description

[github-actions]

Flow PHP - Benchmarks

^{_{Results of the benchmarks from this PR are compared with the results from 1.x branch.}}

Extractors

+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.757mb +0.00%  | 673.059ms +0.33% | ±0.96% +42.98%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.621mb +0.01%   | 301.481ms +1.54% | ±1.12% +159.91% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.781mb +0.01%   | 914.367ms -0.24% | ±2.20% -4.02%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.490mb +0.00% | 1.101s +1.89%    | ±0.52% +9.38%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.560mb +0.00%   | 23.929ms +1.38%  | ±1.44% +102.35% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.560mb +0.00%   | 407.020ms +0.55% | ±1.03% -68.98%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+

Transformers

+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.246mb +0.00% | 61.315ms -2.66% | ±0.27% -86.45% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+

Loaders

+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.417mb +0.00%  | 443.419ms -0.38% | ±1.22% +57.28% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.727mb +0.00%  | 70.144ms -0.64%  | ±0.33% -76.62% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 104.999mb +0.00% | 54.623ms -0.13%  | ±0.62% -69.25% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.477mb +0.00% | 1.470s +0.26%    | ±0.27% -51.96% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.601mb +0.00%  | 41.356ms -0.84%  | ±0.67% -33.11% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+

Building Blocks

+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.300mb +0.00%  | 2.670ms +4.34%   | ±1.96% +212.15%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.091mb +0.00%  | 177.148ms -0.68% | ±0.89% -32.93%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.617mb +0.00%  | 17.569ms -2.14%  | ±0.31% -54.91%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.540mb +0.00%  | 1.735ms +1.74%   | ±2.26% +51.30%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.540mb +0.00%  | 1.876ms +10.36%  | ±2.88% +1820.39% |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.653mb +0.00%  | 2.535ms +0.86%   | ±3.10% +59.13%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.181mb +0.00%  | 14.470ms +2.04%  | ±0.73% -24.24%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.181mb +0.00%  | 14.151ms +1.77%  | ±1.04% -22.65%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.084mb +0.00%  | 1.706μs 0.00%    | ±2.72% 0.00%     |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.084mb +0.00%  | 0.300μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.641mb +0.00%  | 12.791ms +0.88%  | ±1.83% +130.65%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.001mb +0.00% | 63.656ms +2.00%  | ±1.80% -30.84%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.702mb +0.00%  | 1.923ms +1.76%   | ±2.43% -23.53%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.968mb +0.00%  | 33.387ms +0.99%  | ±2.96% +224.82%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.802mb +0.00%  | 3.855ms +1.01%   | ±1.72% -48.10%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.227mb +0.00%  | 38.496ms -0.19%  | ±1.33% +412.57%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.228mb +0.00%  | 39.161ms +0.97%  | ±1.31% +104.46%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.227mb +0.00%  | 39.554ms +2.04%  | ±1.16% -30.22%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.527mb +0.00%  | 7.346ms -2.15%   | ±0.47% -85.86%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.084mb +0.00%  | 28.482ms -0.12%  | ±0.29% -78.73%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.084mb +0.00%  | 13.106μs +0.14%  | ±0.36% -50.38%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.084mb +0.00%  | 16.217μs +2.24%  | ±1.34% -44.13%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.092mb +0.00%  | 180.670ms -2.41% | ±0.28% -60.76%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.173mb +0.00%  | 327.446ms +0.17% | ±0.93% +29.15%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.096mb +0.00%  | 66.125ms +3.29%  | ±0.85% -5.45%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.843mb +0.00% | 379.763ms +2.05% | ±1.05% +95.59%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.561mb +0.00%  | 190.241ms +1.24% | ±1.06% +151.40%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.686mb +0.00%  | 39.886ms +1.44%  | ±1.16% +0.93%    |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+