Skip to content

Improve Dbal Bulk coverage#823

Merged
stloyd merged 1 commit intoflow-php:1.xfrom
stloyd:chore/dbal-bulk-cover
Nov 22, 2023
Merged

Improve Dbal Bulk coverage#823
stloyd merged 1 commit intoflow-php:1.xfrom
stloyd:chore/dbal-bulk-cover

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 22, 2023

Change Log

Added

Fixed

Changed

  • Improve Dbal Bulk coverage

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.759mb +0.00%  | 686.392ms +0.25% | ±0.78% -48.96%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.624mb +0.01%   | 300.115ms -0.13% | ±0.86% +98.19%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.783mb +0.01%   | 967.223ms +4.49% | ±3.86% +527.10% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.493mb +0.00% | 1.102s +0.54%    | ±0.60% +436.29% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.562mb +0.01%   | 24.958ms +2.37%  | ±1.30% +67.47%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.563mb +0.01%   | 408.402ms -0.02% | ±0.27% +54.12%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.247mb +0.00% | 65.107ms +4.75% | ±3.57% +62.69% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.420mb +0.00%  | 447.857ms +0.93% | ±0.85% +36.67%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.729mb +0.00%  | 73.454ms +3.23%  | ±0.19% -82.92%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.002mb +0.00% | 56.338ms +3.58%  | ±0.45% -73.87%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.480mb +0.00% | 1.488s +0.83%    | ±0.51% -64.62%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.604mb +0.00%  | 42.400ms +3.37%  | ±2.72% +487.95% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.301mb +0.00%  | 3.200ms +18.86%  | ±1.59% +44.88%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.092mb +0.00%  | 176.988ms -0.46% | ±0.11% -83.41%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.618mb +0.00%  | 17.897ms +1.43%  | ±0.64% +129.27% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.541mb +0.00%  | 2.150ms +31.49%  | ±0.56% -71.27%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.541mb +0.00%  | 2.182ms +32.49%  | ±2.07% -40.28%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.653mb +0.00%  | 2.943ms +14.38%  | ±2.27% +447.29% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.182mb +0.00%  | 14.987ms +7.19%  | ±0.26% -73.85%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.182mb +0.00%  | 14.602ms +3.81%  | ±2.48% +217.26% |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.085mb +0.00%  | 1.894μs +5.57%   | ±2.53% -5.36%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.085mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.642mb +0.00%  | 12.107ms -0.99%  | ±2.79% +160.60% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.001mb +0.00% | 64.286ms +5.39%  | ±2.93% +34.41%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.703mb +0.00%  | 1.800ms +2.28%   | ±0.61% +109.83% |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.969mb +0.00%  | 33.311ms +1.35%  | ±2.46% +243.97% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.803mb +0.00%  | 3.838ms +0.22%   | ±1.13% -24.10%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.228mb +0.00%  | 38.960ms -1.20%  | ±1.46% -27.96%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.229mb +0.00%  | 38.725ms -2.10%  | ±0.41% +1.65%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.228mb +0.00%  | 39.122ms -0.46%  | ±0.28% -34.95%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.527mb +0.00%  | 7.465ms +0.82%   | ±0.58% +36.62%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.085mb +0.00%  | 28.498ms +0.49%  | ±0.61% +141.58% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.085mb +0.00%  | 13.699μs +4.48%  | ±1.79% +149.69% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.085mb +0.00%  | 15.821μs -1.81%  | ±0.79% -51.88%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.093mb +0.00%  | 183.423ms +1.86% | ±0.31% +4.65%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.174mb +0.00%  | 327.103ms -0.03% | ±2.28% +129.98% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.097mb +0.00%  | 63.785ms -0.53%  | ±0.64% +278.28% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.844mb +0.00% | 371.590ms -0.64% | ±2.47% +629.49% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.562mb +0.00%  | 187.631ms -0.23% | ±0.50% +7.27%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.687mb +0.00%  | 38.811ms -0.66%  | ±2.52% +176.71% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@stloyd stloyd merged commit adc4e68 into flow-php:1.x Nov 22, 2023
@stloyd stloyd deleted the chore/dbal-bulk-cover branch November 22, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants