Skip to content

Use references instead of array of strings in Charts#833

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/charts-references
Nov 23, 2023
Merged

Use references instead of array of strings in Charts#833
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:feature/charts-references

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Use references instead of array of strings in Charts

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.763mb +0.00%  | 678.977ms -0.57% | ±1.12% -7.80%   |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.628mb +0.01%   | 297.628ms +0.60% | ±0.42% -2.40%   |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.787mb +0.01%   | 916.507ms +0.82% | ±0.90% -51.84%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.497mb +0.00% | 1.089s -0.09%    | ±0.24% +116.57% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.566mb +0.01%   | 23.633ms -1.16%  | ±1.68% +7.37%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.567mb +0.01%   | 405.840ms -1.35% | ±0.28% -37.67%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.251mb +0.00% | 62.334ms +1.54% | ±1.52% +22.27% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.424mb +0.00%  | 443.347ms -0.40% | ±0.98% -40.93%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.733mb +0.00%  | 68.523ms -8.81%  | ±1.21% -67.06%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.006mb +0.00% | 53.933ms +0.31%  | ±0.67% +0.93%   |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.484mb +0.00% | 1.457s -1.07%    | ±2.64% +32.29%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.608mb +0.00%  | 39.864ms -3.68%  | ±1.72% +294.08% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.302mb +0.00%  | 2.678ms -4.42%   | ±1.20% -26.14%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.093mb +0.00%  | 175.361ms -2.25% | ±0.49% -47.73%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.618mb +0.00%  | 17.503ms -1.76%  | ±2.82% +465.18% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.542mb +0.00%  | 1.675ms -2.98%   | ±1.94% -38.80%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.542mb +0.00%  | 1.669ms +0.42%   | ±1.91% +6.81%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.654mb +0.00%  | 2.468ms -4.30%   | ±2.21% +1.10%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.183mb +0.00%  | 14.064ms -2.68%  | ±2.92% +176.10% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.183mb +0.00%  | 14.312ms -1.18%  | ±0.64% +18.28%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.086mb +0.00%  | 1.706μs -9.92%   | ±2.72% +7.69%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.086mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00% |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.643mb +0.00%  | 12.130ms -1.14%  | ±2.28% +25.62%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.002mb +0.00% | 61.669ms -1.26%  | ±0.92% -57.03%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.703mb +0.00%  | 1.737ms -5.19%   | ±1.26% +19.31%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.973mb +0.00%  | 33.083ms +0.12%  | ±1.30% +132.79% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.804mb +0.00%  | 3.822ms -0.21%   | ±0.64% -44.29%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.229mb +0.00%  | 38.633ms +0.21%  | ±0.37% -70.17%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.229mb +0.00%  | 38.502ms +0.53%  | ±0.77% +133.76% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.229mb +0.00%  | 38.717ms -0.35%  | ±1.09% -10.48%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.528mb +0.00%  | 7.320ms +0.85%   | ±0.55% +80.56%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.086mb +0.00%  | 28.624ms +2.17%  | ±0.79% +53.65%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.086mb +0.00%  | 13.300μs -2.06%  | ±0.00% -100.00% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.086mb +0.00%  | 15.858μs -0.23%  | ±1.84% +519.30% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.094mb +0.00%  | 179.327ms -3.28% | ±2.09% +97.19%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.174mb +0.00%  | 324.056ms -1.62% | ±0.46% -47.57%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.097mb +0.00%  | 63.886ms -3.33%  | ±0.63% -36.87%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.845mb +0.00% | 366.646ms -3.45% | ±0.63% -55.74%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.563mb +0.00%  | 186.972ms +0.43% | ±1.25% +37.61%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.688mb +0.00%  | 39.295ms -0.14%  | ±0.41% -51.60%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 06a9b84 into flow-php:1.x Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant