Skip to content

Reorganized tests & added isTrue/isFalse functions#844

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:chores/tests-reorganization
Nov 27, 2023
Merged

Reorganized tests & added isTrue/isFalse functions#844
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:chores/tests-reorganization

Conversation

@norberttech
Copy link
Member

Change Log

Added

  • ref()->isTrue()
  • ref()->isFalse()

Fixed

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.763mb +0.00%  | 696.296ms +2.31% | ±2.82% +29.76%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.628mb +0.03%   | 298.103ms -0.73% | ±0.55% -75.40%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.787mb +0.03%   | 898.484ms -4.30% | ±1.40% -3.34%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.497mb +0.00% | 1.087s +0.16%    | ±1.17% -2.56%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.568mb +0.03%   | 23.679ms -0.60%  | ±1.84% +560.25% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.568mb +0.03%   | 403.244ms -0.61% | ±0.29% -54.32%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.251mb +0.00% | 64.340ms -0.32% | ±3.17% +372.53% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.424mb +0.00%  | 461.038ms -2.75% | ±2.80% -28.30%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.733mb +0.00%  | 71.681ms +0.93%  | ±0.38% -68.12%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.005mb +0.00% | 54.316ms -4.99%  | ±0.17% -76.56%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.484mb +0.00% | 1.507s +0.39%    | ±3.37% +105.58% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.608mb +0.01%  | 41.815ms -2.88%  | ±2.41% +88.51%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.301mb +0.00%  | 3.060ms -2.26%   | ±3.24% +45.20%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.091mb +0.00%  | 177.809ms +0.79% | ±0.19% -88.82%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.617mb +0.00%  | 17.793ms +0.27%  | ±0.17% -71.95%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.541mb +0.00%  | 1.828ms -8.90%   | ±0.94% -22.10%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.541mb +0.00%  | 1.922ms -4.60%   | ±1.21% +13.76%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.653mb +0.00%  | 2.835ms +1.27%   | ±1.04% -51.06%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.182mb +0.00%  | 14.393ms -2.53%  | ±0.93% -54.37%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.182mb +0.00%  | 14.726ms -1.45%  | ±1.65% +36.35%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.085mb +0.00%  | 1.900μs -5.00%   | ±0.00% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.085mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.642mb +0.00%  | 12.848ms +1.85%  | ±1.16% -55.43%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.001mb +0.00% | 62.043ms -1.56%  | ±0.43% -55.00%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.702mb +0.00%  | 2.051ms +1.97%   | ±1.61% -28.67%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.973mb +0.00%  | 34.808ms +0.11%  | ±1.40% +291.84% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.803mb +0.00%  | 4.046ms -5.47%   | ±2.10% -30.37%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.228mb +0.00%  | 38.934ms -1.32%  | ±0.71% -46.61%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.228mb +0.00%  | 39.046ms -2.16%  | ±2.36% +767.94% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.228mb +0.00%  | 39.606ms -1.24%  | ±0.59% -19.03%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.527mb +0.00%  | 7.380ms -1.68%   | ±0.60% -33.89%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.085mb +0.00%  | 28.840ms -0.10%  | ±1.45% +468.54% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.085mb +0.00%  | 13.812μs +3.23%  | ±0.68% -46.13%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.085mb +0.00%  | 15.918μs -5.54%  | ±0.88% -61.02%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.093mb +0.00%  | 178.073ms -2.52% | ±0.55% +19.24%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.173mb +0.00%  | 320.327ms -0.45% | ±0.26% -67.94%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.096mb +0.01%  | 63.172ms -0.55%  | ±0.69% -19.09%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.843mb +0.00% | 359.497ms -0.28% | ±0.41% -83.34%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.561mb +0.00%  | 194.300ms +7.83% | ±3.41% +36.07%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.686mb +0.01%  | 38.555ms -3.09%  | ±1.07% -39.97%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit dac229f into flow-php:1.x Nov 27, 2023
@norberttech norberttech deleted the chores/tests-reorganization branch December 5, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant