Skip to content

Allow usage of Symfony 7#851

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
stloyd:chore/allow-sf7
Nov 29, 2023
Merged

Allow usage of Symfony 7#851
norberttech merged 1 commit intoflow-php:1.xfrom
stloyd:chore/allow-sf7

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 29, 2023

Change Log

Added

Fixed

Changed

  • Allow usage of Symfony 7

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.766mb +0.00%  | 672.274ms -3.67% | ±0.93% -65.76%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.631mb +0.00%   | 299.977ms -0.29% | ±1.22% -66.31%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.790mb +0.00%   | 900.932ms -2.72% | ±0.67% -69.15%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.499mb +0.00% | 1.092s +0.61%    | ±0.56% -18.26%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.571mb +0.00%   | 23.756ms -0.51%  | ±0.28% -71.47%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.571mb +0.00%   | 406.065ms -0.12% | ±0.51% +537.96% |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.254mb +0.00% | 61.141ms -1.67% | ±0.39% -79.12% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.426mb +0.00%  | 442.287ms -0.44% | ±1.89% +443.07% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.736mb +0.00%  | 69.943ms -2.55%  | ±1.01% +569.61% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.008mb +0.00% | 54.022ms -0.60%  | ±0.26% -91.82%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.486mb +0.00% | 1.546s +3.32%    | ±1.28% -49.18%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.610mb +0.00%  | 41.489ms -2.28%  | ±0.42% +9.71%   |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.303mb +0.00%  | 2.766ms +1.72%   | ±1.46% +73.97%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.096mb +0.00%  | 183.247ms +2.67% | ±0.43% +7.96%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.622mb +0.00%  | 18.425ms +3.78%  | ±1.15% +44.10%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.543mb +0.00%  | 1.898ms +14.91%  | ±0.64% -63.41%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.543mb +0.00%  | 1.779ms +9.96%   | ±1.78% -44.44%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.655mb +0.00%  | 2.646ms +6.36%   | ±1.50% +19.62%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.184mb +0.00%  | 15.065ms +4.13%  | ±3.10% +52.17%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.184mb +0.00%  | 14.724ms +3.29%  | ±1.17% +91.23%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.087mb +0.00%  | 1.806μs +0.68%   | ±2.57% -3.64%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.087mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.644mb +0.00%  | 12.115ms -4.36%  | ±1.45% +113.85% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.003mb +0.00% | 64.033ms +2.68%  | ±1.62% +195.23% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.705mb +0.00%  | 1.998ms +13.27%  | ±1.96% +22.90%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.978mb +0.00%  | 34.646ms +2.63%  | ±0.77% -46.16%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.805mb +0.00%  | 3.827ms -6.56%   | ±0.30% -90.43%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.232mb +0.00%  | 42.008ms +8.13%  | ±1.63% +61.40%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.233mb +0.00%  | 40.116ms +1.41%  | ±0.67% -43.95%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.232mb +0.00%  | 40.833ms +3.40%  | ±2.20% +671.49% |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.530mb +0.00%  | 7.384ms +0.83%   | ±1.65% +132.53% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.087mb +0.00%  | 28.887ms +0.45%  | ±0.47% -41.98%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.087mb +0.00%  | 13.512μs +1.36%  | ±0.69% -60.29%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.087mb +0.00%  | 16.276μs +1.51%  | ±1.17% -9.37%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.097mb +0.00%  | 187.026ms +1.88% | ±1.06% +4.04%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.175mb +0.00%  | 325.996ms +1.36% | ±1.75% +228.78% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.099mb +0.00%  | 63.953ms +0.18%  | ±1.83% +36.06%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.846mb +0.00% | 358.666ms +0.82% | ±1.39% -12.48%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.564mb +0.00%  | 182.207ms +0.38% | ±1.66% -19.87%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.689mb +0.00%  | 39.528ms +2.43%  | ±1.58% +61.83%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@stloyd stloyd requested a review from norberttech November 29, 2023 11:34
@norberttech norberttech merged commit d863800 into flow-php:1.x Nov 29, 2023
@stloyd stloyd deleted the chore/allow-sf7 branch November 29, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants