Skip to content

Fix typo in Snappy polyfill filename#855

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
stloyd:snappy-typo
Dec 1, 2023
Merged

Fix typo in Snappy polyfill filename#855
norberttech merged 1 commit intoflow-php:1.xfrom
stloyd:snappy-typo

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Dec 1, 2023

Change Log

Added

Fixed

  • Fix typo in Snappy polyfill filename

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.122mb +0.00%  | 690.694ms -1.39% | ±2.16% +597.57% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.820mb +0.01%   | 302.787ms +0.17% | ±0.40% +44.73%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.919mb +0.01%   | 925.627ms +0.23% | ±0.34% -60.09%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.625mb +0.00% | 1.126s +0.98%    | ±1.15% +21.46%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.698mb +0.01%   | 24.441ms -4.83%  | ±1.75% +24.15%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.699mb +0.01%   | 406.581ms -0.41% | ±0.69% +2.70%   |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev        |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.385mb +0.00% | 66.769ms +1.81% | ±1.53% -6.85% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.783mb +0.00%  | 439.233ms -7.16% | ±2.80% -18.38% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.860mb +0.00%  | 73.050ms +0.27%  | ±0.65% -45.62% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.443mb +0.00% | 56.797ms +1.45%  | ±0.95% +29.61% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.653mb +0.00% | 1.498s +1.62%    | ±1.14% +59.80% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.737mb +0.00%  | 41.505ms -1.31%  | ±0.67% -32.67% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.435mb +0.00%  | 2.840ms +1.95%   | ±1.01% -34.93%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.228mb +0.00%  | 184.774ms +0.84% | ±0.38% -30.76%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.754mb +0.00%  | 18.285ms -1.03%  | ±0.86% +113.17% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.675mb +0.00%  | 1.693ms -6.50%   | ±3.51% +50.32%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.675mb +0.00%  | 1.759ms -2.88%   | ±1.91% -26.14%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.787mb +0.00%  | 2.593ms -11.03%  | ±1.44% +231.52% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.316mb +0.00%  | 14.235ms -16.08% | ±1.55% +74.25%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.316mb +0.00%  | 14.525ms -13.38% | ±1.06% -44.20%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.219mb +0.00%  | 1.706μs -14.70%  | ±2.72% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.219mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.776mb +0.00%  | 12.561ms -8.51%  | ±2.71% -9.06%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.135mb +0.00% | 64.772ms -1.44%  | ±0.57% -56.79%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.837mb +0.00%  | 1.893ms -4.01%   | ±2.24% -13.54%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 78.110mb +0.00%  | 33.462ms -14.20% | ±1.41% +147.67% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.937mb +0.00%  | 4.062ms -1.51%   | ±1.82% +19.91%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.364mb +0.00%  | 38.925ms -1.68%  | ±0.70% -74.09%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.365mb +0.00%  | 39.022ms -2.01%  | ±0.57% +159.21% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.364mb +0.00%  | 39.647ms -1.39%  | ±1.10% -36.48%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.661mb +0.00%  | 7.322ms -2.43%   | ±1.63% +18.29%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.219mb +0.00%  | 28.462ms -0.99%  | ±2.64% +72.83%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.219mb +0.00%  | 13.380μs +1.49%  | ±1.26% -22.29%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.219mb +0.00%  | 15.712μs -1.29%  | ±0.60% -32.35%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.229mb +0.00%  | 184.235ms +1.51% | ±0.75% -27.06%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.380mb +0.00%  | 330.885ms -1.13% | ±0.31% -38.09%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.303mb +0.00%  | 66.840ms +0.47%  | ±1.47% -18.62%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.978mb +0.00% | 377.383ms -4.65% | ±2.46% +13.41%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.696mb +0.00%  | 192.486ms -0.25% | ±1.68% +126.64% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.821mb +0.00%  | 41.030ms +3.38%  | ±2.58% +433.07% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit ef73956 into flow-php:1.x Dec 1, 2023
@stloyd stloyd deleted the snappy-typo branch December 1, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants