Skip to content

remove LocalFile references in readme and dockblock#863

Merged
norberttech merged 4 commits intoflow-php:1.xfrom
mzarnecki:1.x
Dec 3, 2023
Merged

remove LocalFile references in readme and dockblock#863
norberttech merged 4 commits intoflow-php:1.xfrom
mzarnecki:1.x

Conversation

@mzarnecki
Copy link
Contributor

Change Log

Added

Fixed

Changed

Removed

  • removed LocalFile references in readme and dockblock

Deprecated

Security


@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev         |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.123mb +0.00%  | 699.614ms -1.46% | ±1.15% -41.50% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.822mb +0.00%   | 304.135ms +0.29% | ±0.11% -83.59% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.920mb +0.00%   | 939.185ms +0.04% | ±0.93% -51.32% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.626mb +0.00% | 1.181s +2.49%    | ±0.48% -10.69% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.699mb +0.00%   | 24.854ms -0.38%  | ±0.22% -77.97% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.700mb +0.00%   | 412.778ms +1.25% | ±0.93% +59.60% |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.386mb +0.00% | 72.461ms +3.06% | ±2.64% -11.70% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev          |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.784mb +0.00%  | 493.605ms +10.42% | ±1.48% +333.78% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.862mb +0.00%  | 75.749ms +3.15%   | ±2.10% +130.13% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.445mb +0.00% | 68.301ms +11.98%  | ±3.15% +115.05% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.654mb +0.00% | 1.315s -0.26%     | ±0.63% -22.01%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.739mb +0.00%  | 46.793ms +12.21%  | ±2.88% +397.78% |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.436mb +0.00%  | 2.692ms -20.74%  | ±3.62% +308.10%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.229mb +0.00%  | 187.519ms +0.70% | ±1.28% +92.29%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.755mb +0.00%  | 18.560ms -2.48%  | ±1.41% -34.18%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.676mb +0.00%  | 1.788ms -13.78%  | ±1.68% +130.74%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.676mb +0.00%  | 1.817ms -7.34%   | ±2.18% -42.73%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.789mb +0.00%  | 2.961ms -3.92%   | ±3.02% +672.53%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.318mb +0.00%  | 16.182ms +3.74%  | ±0.96% -70.72%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.318mb +0.00%  | 16.808ms +8.05%  | ±2.49% +302.07%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.220mb +0.00%  | 1.994μs -9.62%   | ±2.40% +13.56%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.220mb +0.00%  | 0.400μs -20.00%  | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.777mb +0.00%  | 12.906ms -14.61% | ±3.31% +80.82%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.137mb +0.00% | 76.753ms +13.15% | ±3.44% +672.36%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.838mb +0.00%  | 2.055ms -5.70%   | ±2.96% +8.45%    |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 78.111mb +0.00%  | 34.698ms -2.22%  | ±0.68% +8.05%    |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.939mb +0.00%  | 4.324ms -5.68%   | ±2.86% +88.07%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.366mb +0.00%  | 39.630ms -9.16%  | ±1.53% +87.92%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.366mb +0.00%  | 40.077ms -8.74%  | ±1.17% -17.13%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.366mb +0.00%  | 40.316ms -7.61%  | ±0.77% -15.12%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.663mb +0.00%  | 7.454ms -9.16%   | ±1.42% -24.22%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.220mb +0.00%  | 29.078ms -7.86%  | ±0.50% -71.36%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.220mb +0.00%  | 13.812μs -2.04%  | ±1.92% +0.00%    |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.220mb +0.00%  | 20.022μs +16.27% | ±2.67% +169.52%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.231mb +0.00%  | 198.987ms +7.95% | ±3.46% +184.99%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.381mb +0.00%  | 344.583ms +1.53% | ±3.28% +1281.56% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.304mb +0.00%  | 68.393ms -1.35%  | ±2.07% +102.70%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.979mb +0.00% | 392.756ms -1.54% | ±2.19% +43.65%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.697mb +0.00%  | 206.185ms +1.74% | ±2.13% +54.98%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.822mb +0.00%  | 41.433ms -5.34%  | ±1.30% -40.94%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech
Copy link
Member

Thanks @rzarn! Since you already touched those files, could you also change the DSL from Text::to into to_text?

@mzarnecki
Copy link
Contributor Author

Thanks @rzarn! Since you already touched those files, could you also change the DSL from Text::to into to_text?

sure, good point

@norberttech norberttech merged commit a9a6afe into flow-php:1.x Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants