Skip to content

Fixed printing null type entries in schema formatter#884

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/schema-formatter
Dec 20, 2023
Merged

Fixed printing null type entries in schema formatter#884
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/schema-formatter

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • printing null type entries in schema formatted

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.154mb -0.00%  | 720.154ms +2.11% | ±1.45% +792.93% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.801mb +0.01%   | 306.652ms +0.20% | ±0.39% +29.69%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.900mb +0.01%   | 946.388ms +2.59% | ±0.82% +32.68%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.613mb +0.00% | 1.122s -0.97%    | ±2.22% +98.48%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.676mb +0.01%   | 26.451ms -2.14%  | ±0.84% +102.45% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.678mb +0.01%   | 415.470ms -0.16% | ±0.97% +521.77% |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev        |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.405mb +0.00% | 64.772ms -0.97% | ±1.12% +8.85% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.770mb +0.00%  | 443.955ms -5.06% | ±2.43% +27.50% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.849mb +0.00%  | 70.681ms -1.03%  | ±0.56% -63.87% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.431mb +0.00% | 58.302ms -1.72%  | ±1.53% -17.55% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.641mb +0.00% | 1.285s -0.96%    | ±0.30% -71.35% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.726mb +0.00%  | 40.162ms -2.62%  | ±0.82% +19.91% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.049mb +0.00% | 390.683ms +0.21% | ±0.84% -55.52%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.767mb +0.00%  | 192.861ms -0.45% | ±0.33% -63.35%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.843mb +0.00%  | 40.182ms -3.75%  | ±3.16% +264.14%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.399mb +0.00%  | 330.928ms -1.63% | ±0.46% -32.03%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.322mb +0.00%  | 65.441ms -5.27%  | ±1.53% +173.44%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.464mb +0.00%  | 3.709ms -9.62%   | ±3.20% +1.00%    |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.256mb +0.00%  | 182.266ms +0.39% | ±1.12% +819.04%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.782mb +0.00%  | 18.249ms -0.51%  | ±0.86% +188.53%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.704mb +0.00%  | 1.839ms -18.45%  | ±1.32% -33.90%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.704mb +0.00%  | 1.904ms -11.57%  | ±3.07% +260.91%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.815mb +0.00%  | 2.684ms -11.80%  | ±1.70% -29.39%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.345mb +0.00%  | 15.863ms -8.94%  | ±2.61% +137.64%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.345mb +0.00%  | 15.810ms -11.56% | ±0.90% -31.47%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.248mb +0.00%  | 1.694μs -11.13%  | ±2.83% +16.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.248mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.870mb +0.00%  | 15.213ms +6.44%  | ±1.63% -51.34%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.164mb +0.00% | 66.268ms -2.60%  | ±1.72% -39.65%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.865mb +0.00%  | 1.682ms +8.11%   | ±2.98% +2300.04% |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 78.138mb +0.00%  | 40.484ms +0.25%  | ±0.50% +218.34%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.966mb +0.00%  | 4.384ms +0.70%   | ±2.48% -14.55%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.393mb +0.00%  | 40.561ms +0.46%  | ±1.58% +50.87%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.394mb +0.00%  | 40.235ms -2.39%  | ±1.91% +248.03%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.393mb +0.00%  | 41.905ms +3.16%  | ±0.92% -40.29%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.690mb +0.00%  | 7.534ms -2.66%   | ±1.76% -54.85%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.248mb +0.00%  | 29.442ms -2.44%  | ±1.11% +6.61%    |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.248mb +0.00%  | 14.399μs +0.04%  | ±2.27% +591.22%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.248mb +0.00%  | 17.524μs +0.82%  | ±3.05% +272.62%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.258mb +0.00%  | 184.745ms -2.02% | ±0.31% -58.93%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit 607bf77 into flow-php:1.x Dec 20, 2023
@norberttech norberttech deleted the bug/schema-formatter branch December 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants