Skip to content

Revert removal of compressing serializer#899

Merged
norberttech merged 2 commits intoflow-php:1.xfrom
norberttech:revert/removal-of-compressing-serializer
Jan 1, 2024
Merged

Revert removal of compressing serializer#899
norberttech merged 2 commits intoflow-php:1.xfrom
norberttech:revert/removal-of-compressing-serializer

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Reverted removed copmressing serializer

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.142mb -0.04%  | 751.209ms -0.16% | ±0.30% -52.73%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.779mb +0.07%   | 344.894ms +0.80% | ±2.45% +460.89% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.871mb +0.12%   | 986.825ms +0.61% | ±2.09% +388.87% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.575mb +0.00% | 1.141s -0.56%    | ±0.78% +34.40%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.654mb +0.16%   | 57.640ms +0.38%  | ±0.74% +51.80%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.655mb +0.16%   | 468.779ms +0.94% | ±0.14% -71.41%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.368mb +0.01% | 63.936ms +1.09% | ±0.82% +45.45% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.733mb +0.01%  | 447.187ms -3.45% | ±0.30% -56.46%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.817mb +0.01%  | 71.447ms +0.89%  | ±0.34% +12.87%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.326mb +0.01% | 56.556ms -0.49%  | ±1.02% -59.03%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.537mb +0.00% | 1.260s -0.20%    | ±0.34% +419.46% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.698mb +0.03%  | 40.967ms -0.80%  | ±0.39% -71.59%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.993mb -0.00% | 398.337ms +2.61% | ±1.47% +16.22%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.712mb -0.00%  | 198.695ms +2.67% | ±0.94% -21.06%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.836mb -0.01%  | 41.640ms +1.31%  | ±1.16% +7.10%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.397mb +0.00%  | 328.759ms +0.49% | ±0.53% +16.42%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.321mb +0.00%  | 64.754ms +0.15%  | ±0.33% -48.84%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.456mb +0.00%  | 3.871ms +2.22%   | ±1.09% +50.24%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.249mb +0.00%  | 186.402ms +1.87% | ±0.21% -52.96%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.774mb +0.00%  | 18.237ms -2.61%  | ±0.92% +7.41%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.696mb +0.00%  | 1.690ms -10.39%  | ±1.84% -43.78%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.696mb +0.00%  | 1.668ms -5.17%   | ±1.07% -2.28%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.808mb +0.00%  | 2.496ms -4.53%   | ±1.27% -47.85%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.337mb +0.00%  | 14.743ms -2.40%  | ±2.08% +139.62% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.337mb +0.00%  | 14.796ms -0.42%  | ±1.39% +12.12%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.240mb +0.00%  | 1.794μs -0.34%   | ±2.67% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.240mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.798mb -0.00%  | 12.755ms -1.13%  | ±1.42% +64.18%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.156mb +0.00% | 64.764ms +4.10%  | ±1.40% +89.84%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.857mb +0.00%  | 1.265ms -11.73%  | ±1.14% -50.64%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.203mb +0.00%  | 59.117ms +3.51%  | ±0.19% -84.62%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.958mb +0.00%  | 3.859ms -4.57%   | ±1.23% +134.54% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.385mb +0.00%  | 41.162ms -0.40%  | ±0.75% -26.35%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.386mb +0.00%  | 41.188ms -0.94%  | ±1.57% +15.78%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.385mb +0.00%  | 41.945ms +3.94%  | ±1.24% +31.24%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.682mb +0.00%  | 7.487ms -0.04%   | ±0.86% -38.52%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.240mb +0.00%  | 29.690ms -0.11%  | ±1.33% +174.69% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.240mb +0.00%  | 13.720μs -2.61%  | ±1.25% +85.57%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.240mb +0.00%  | 15.924μs -0.35%  | ±1.18% +11.17%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.250mb +0.00%  | 189.839ms +2.03% | ±0.87% +319.38% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 7595a53 into flow-php:1.x Jan 1, 2024
@norberttech norberttech deleted the revert/removal-of-compressing-serializer branch December 5, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant