Skip to content

Fixed converting list of structures to parquet schema#900

Merged
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/parquet-schema-converter
Jan 1, 2024
Merged

Fixed converting list of structures to parquet schema#900
norberttech merged 1 commit intoflow-php:1.xfrom
norberttech:bug/parquet-schema-converter

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • converting list of structures to parquet schema

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev           |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.128mb +0.00%  | 758.364ms +0.08% | ±1.99% +2242.03% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.782mb +0.01%   | 343.750ms +0.11% | ±0.89% +209.80%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.876mb +0.01%   | 992.001ms +1.59% | ±0.88% +162.71%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.581mb +0.00% | 1.139s +0.39%    | ±0.87% -14.46%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.661mb +0.01%   | 57.411ms +0.32%  | ±1.11% +86.12%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.663mb +0.01%   | 471.566ms +1.81% | ±1.15% -20.76%   |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.376mb +0.00% | 63.123ms -0.76% | ±0.96% +130.03% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.739mb +0.00%  | 459.695ms +2.04% | ±3.18% +329.58% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.820mb +0.00%  | 73.760ms -0.23%  | ±1.32% +481.33% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.332mb +0.00% | 57.603ms +0.05%  | ±0.23% -73.29%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.543mb +0.00% | 1.285s +1.04%    | ±2.94% +286.41% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.703mb +0.00%  | 41.616ms -0.99%  | ±0.36% -39.68%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.992mb +0.00% | 393.696ms -1.52% | ±1.52% +375.84% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.710mb +0.00%  | 198.307ms +2.19% | ±1.31% -22.97%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.835mb +0.00%  | 41.610ms +0.64%  | ±1.42% -16.36%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.398mb +0.00%  | 328.287ms -0.60% | ±1.19% +202.70% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.321mb +0.00%  | 65.973ms +2.13%  | ±2.95% +95.38%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.456mb +0.00%  | 4.271ms +3.09%   | ±0.63% -81.37%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.249mb +0.00%  | 192.374ms +6.28% | ±1.39% +0.33%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.775mb +0.00%  | 19.303ms +6.18%  | ±0.49% -76.36%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.696mb +0.00%  | 2.011ms +21.77%  | ±0.76% -73.59%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.696mb +0.00%  | 2.063ms +10.62%  | ±3.48% +124.20% |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.808mb +0.00%  | 2.905ms +8.58%   | ±1.34% -25.02%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.337mb +0.00%  | 15.129ms -5.47%  | ±0.92% -76.74%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.337mb +0.00%  | 15.202ms -0.58%  | ±0.99% +225.08% |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.240mb +0.00%  | 1.894μs -0.64%   | ±2.53% +3.57%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.240mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.796mb +0.00%  | 13.806ms +4.60%  | ±0.88% -66.62%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.157mb +0.00% | 64.300ms +0.42%  | ±1.68% +287.62% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.857mb +0.00%  | 1.680ms +28.44%  | ±1.01% -44.41%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.204mb +0.00%  | 60.874ms +6.11%  | ±0.80% +8.23%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.959mb +0.00%  | 4.351ms +12.32%  | ±0.93% -49.47%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.385mb +0.00%  | 40.953ms +0.35%  | ±0.57% -44.25%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.386mb +0.00%  | 42.252ms +4.37%  | ±1.35% -57.75%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.385mb +0.00%  | 41.534ms +1.65%  | ±0.42% -84.60%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.683mb +0.00%  | 7.780ms +5.04%   | ±0.28% -86.64%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.240mb +0.00%  | 29.740ms -0.60%  | ±0.81% -10.89%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.240mb +0.00%  | 15.001μs +8.56%  | ±2.40% +136.36% |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.240mb +0.00%  | 16.480μs +3.45%  | ±1.03% -30.07%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.250mb +0.00%  | 193.860ms +7.24% | ±0.79% +129.22% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 014b7c3 into flow-php:1.x Jan 1, 2024
@norberttech norberttech deleted the bug/parquet-schema-converter branch December 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant