Skip to content

add csv adapter unit test for fixture not yet in use#910

Merged
norberttech merged 21 commits intoflow-php:1.xfrom
mzarnecki:1.x
Jan 15, 2024
Merged

add csv adapter unit test for fixture not yet in use#910
norberttech merged 21 commits intoflow-php:1.xfrom
mzarnecki:1.x

Conversation

@mzarnecki
Copy link
Contributor

Change Log

Added

  • add csv adapter unit test for fixture not yet in use

Fixed

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.129mb -0.00%  | 749.235ms -2.19% | ±0.13% -89.74%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.782mb +0.02%   | 341.511ms -0.53% | ±1.44% -55.70%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.877mb +0.02%   | 981.902ms +1.31% | ±1.03% +9.17%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.581mb +0.00% | 1.131s +0.05%    | ±1.95% +128.00% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.661mb +0.02%   | 54.088ms -0.05%  | ±0.72% +9.00%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.663mb +0.02%   | 467.706ms +1.59% | ±0.72% -43.99%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.375mb +0.00% | 62.769ms +0.77% | ±1.11% +16.77% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+------------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev           |
+--------------------+----------------+------+-----+------------------+------------------+------------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.739mb +0.00%  | 447.833ms +0.80% | ±1.17% +182.35%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.820mb +0.00%  | 73.209ms +3.09%  | ±1.14% +261.19%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.333mb +0.00% | 56.431ms +2.04%  | ±1.10% +1069.39% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.543mb +0.00% | 1.264s +0.95%    | ±0.54% +230.00%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.703mb +0.00%  | 41.182ms +3.68%  | ±0.57% +130.62%  |
+--------------------+----------------+------+-----+------------------+------------------+------------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.992mb +0.00% | 388.632ms -0.42% | ±1.08% +31.98%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.710mb +0.00%  | 192.814ms -2.84% | ±0.98% +5.98%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.835mb +0.00%  | 41.131ms -0.17%  | ±0.83% +29.86%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.398mb +0.00%  | 326.384ms +0.33% | ±1.04% -26.83%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.321mb +0.00%  | 65.373ms +0.72%  | ±1.41% +13.38%   |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.456mb +0.00%  | 3.218ms +2.51%   | ±0.80% +16.41%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.249mb +0.00%  | 180.812ms -5.99% | ±0.80% -12.55%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.775mb +0.00%  | 18.054ms -6.78%  | ±0.59% -54.31%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.696mb +0.00%  | 1.673ms +3.33%   | ±1.36% +6.64%    |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.696mb +0.00%  | 1.718ms +9.11%   | ±1.96% -30.84%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.808mb +0.00%  | 2.532ms +2.47%   | ±0.82% +746.79%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.337mb +0.00%  | 14.898ms -3.48%  | ±2.82% +174.87%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.337mb +0.00%  | 14.722ms +3.52%  | ±2.76% +46.46%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.240mb +0.00%  | 1.606μs 0.00%    | ±2.89% 0.00%     |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.240mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.796mb +0.00%  | 12.490ms -2.39%  | ±0.94% -11.11%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.156mb +0.00% | 62.827ms +1.48%  | ±0.70% +155.95%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.857mb +0.00%  | 1.210ms +5.26%   | ±1.98% -4.60%    |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.204mb +0.00%  | 56.698ms -0.27%  | ±0.83% +16.10%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.958mb +0.00%  | 3.798ms +0.06%   | ±0.50% -83.45%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.385mb +0.00%  | 39.845ms -2.97%  | ±2.26% +1011.54% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.386mb +0.00%  | 39.660ms -4.88%  | ±0.67% -53.15%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.385mb +0.00%  | 39.902ms -3.26%  | ±0.71% +46.05%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.682mb +0.00%  | 7.358ms -0.24%   | ±0.40% +114.41%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.240mb +0.00%  | 28.931ms -1.76%  | ±0.35% -85.38%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.240mb +0.00%  | 12.983μs +0.41%  | ±1.65% -8.58%    |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.240mb +0.00%  | 15.424μs -0.99%  | ±1.21% +52.16%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.250mb +0.00%  | 181.593ms -6.37% | ±0.57% +2.08%    |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@mzarnecki mzarnecki closed this Jan 8, 2024
@mzarnecki mzarnecki reopened this Jan 8, 2024
@mzarnecki mzarnecki marked this pull request as draft January 8, 2024 22:13
@mzarnecki mzarnecki marked this pull request as ready for review January 8, 2024 22:34
@mzarnecki mzarnecki marked this pull request as draft January 9, 2024 21:13
@mzarnecki mzarnecki marked this pull request as ready for review January 9, 2024 22:02
@norberttech norberttech merged commit 47daf9f into flow-php:1.x Jan 15, 2024
@norberttech
Copy link
Member

Thanks, @rzarno, great catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants