Skip to content

Fixed handling empty headers#942

Merged
norberttech merged 2 commits intoflow-php:1.xfrom
norberttech:bug/csv-empty-headers
Jan 31, 2024
Merged

Fixed handling empty headers#942
norberttech merged 2 commits intoflow-php:1.xfrom
norberttech:bug/csv-empty-headers

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • handling empty headers in CSV files

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.261mb +0.00%  | 820.255ms +0.60% | ±0.61% -51.79%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.978mb +0.05%   | 340.195ms -0.68% | ±0.38% +127.82% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.130mb +0.00%   | 1.053s +0.08%    | ±1.91% +212.68% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.835mb +0.00% | 1.246s -1.07%    | ±0.34% -46.70%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.899mb +0.01%   | 34.646ms -0.81%  | ±0.61% +43.32%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.901mb +0.01%   | 438.646ms +2.00% | ±1.03% +164.11% |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.601mb +0.00% | 65.523ms -1.64% | ±0.33% -54.44% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.641mb +0.00%  | 465.789ms -2.07% | ±0.34% +44.75% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.115mb +0.00%  | 72.773ms +0.28%  | ±0.36% -53.23% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.546mb +0.00% | 52.358ms +0.79%  | ±0.16% -71.17% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 321.757mb +0.00% | 1.486s -1.44%    | ±0.35% -65.52% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.939mb +0.00%  | 41.700ms +4.91%  | ±1.42% -33.78% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.676mb +0.00%  | 3.558ms +8.15%   | ±3.50% +88.65%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.403mb +0.00%  | 180.043ms -1.27% | ±0.38% -29.09%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.928mb +0.00%  | 17.790ms -1.88%  | ±0.11% -94.65%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.916mb +0.00%  | 1.661ms -6.39%   | ±0.42% -82.44%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.916mb +0.00%  | 1.716ms +0.72%   | ±1.67% +35.03%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 75.028mb +0.00%  | 2.531ms -3.34%   | ±0.51% -65.41%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.557mb +0.00%  | 14.918ms +3.80%  | ±0.80% -53.66%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.557mb +0.00%  | 14.886ms +2.72%  | ±0.85% -56.79%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.461mb +0.00%  | 1.806μs +12.45%  | ±2.57% -10.91%  |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.461mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 87.015mb +0.00%  | 12.837ms +1.41%  | ±0.82% -65.86%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.376mb +0.00% | 63.900ms -4.00%  | ±0.99% -47.51%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 76.076mb +0.00%  | 1.270ms -2.69%   | ±2.25% -32.39%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.423mb +0.00%  | 56.130ms +1.24%  | ±1.35% +6.26%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 78.178mb +0.00%  | 3.786ms -1.00%   | ±0.46% -28.90%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.539mb +0.00%  | 39.990ms +1.23%  | ±1.12% -40.73%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.540mb +0.00%  | 40.226ms -0.43%  | ±1.29% +93.10%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.539mb +0.00%  | 39.953ms -0.37%  | ±1.27% +8.58%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.902mb +0.00%  | 7.453ms +1.29%   | ±0.83% +313.81% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.461mb +0.00%  | 29.038ms -0.12%  | ±1.13% -43.09%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.461mb +0.00%  | 13.306μs +0.09%  | ±0.35% -0.50%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.461mb +0.00%  | 15.583μs -1.74%  | ±1.38% -11.93%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.404mb +0.00%  | 182.898ms -0.63% | ±0.72% -32.79%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.707mb +0.00% | 477.875ms -3.94% | ±1.55% +334.88% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.186mb +0.00%  | 250.805ms +0.94% | ±1.15% +27.21%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.119mb +0.00%  | 52.417ms -0.21%  | ±1.72% +4.61%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.958mb +0.00%  | 432.202ms -0.77% | ±0.78% -30.54%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.497mb +0.00%  | 85.318ms -0.02%  | ±0.84% +57.54%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@github-actions github-actions bot added the core label Jan 30, 2024
@norberttech norberttech merged commit 0662851 into flow-php:1.x Jan 31, 2024
@norberttech norberttech deleted the bug/csv-empty-headers branch December 5, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant