Skip to content

Fixed Caching Pipeline & Build #958

Merged
norberttech merged 3 commits intoflow-php:1.xfrom
norberttech:feature/caching-rows
Feb 3, 2024
Merged

Fixed Caching Pipeline & Build #958
norberttech merged 3 commits intoflow-php:1.xfrom
norberttech:feature/caching-rows

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • building phar
  • CachingPipeline - by not clearing cache when it already has items

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.269mb +0.00%  | 826.109ms +1.05% | ±0.79% -10.64%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.989mb +0.01%   | 342.577ms +0.18% | ±0.38% -5.05%   |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.139mb +0.01%   | 1.053s -0.08%    | ±1.03% +29.33%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.843mb +0.00% | 1.261s +1.12%    | ±0.53% +376.10% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.903mb +0.01%   | 35.541ms +0.21%  | ±1.67% +27.80%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.904mb +0.01%   | 434.124ms -1.17% | ±0.77% +87.46%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.608mb +0.00% | 65.893ms +2.43% | ±0.72% -15.86% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.649mb +0.00%  | 460.003ms +0.35% | ±0.20% -90.12% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.125mb +0.00%  | 73.402ms +2.03%  | ±1.26% -12.06% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.554mb +0.00% | 53.740ms -0.07%  | ±0.42% -36.28% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 321.765mb +0.00% | 1.499s +1.22%    | ±0.64% -60.19% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.948mb +0.00%  | 41.167ms -0.30%  | ±0.48% -15.63% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.715mb +0.00% | 490.888ms +0.08% | ±0.32% -79.56%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.193mb +0.00%  | 252.707ms +2.96% | ±0.61% -14.52%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.127mb +0.00%  | 53.186ms +2.84%  | ±2.63% +225.27% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.961mb +0.00%  | 438.896ms +1.05% | ±0.95% +79.88%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.500mb +0.00%  | 87.597ms +2.73%  | ±0.79% -5.11%   |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.683mb +0.00%  | 3.822ms +7.06%   | ±1.42% -39.09%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.410mb +0.00%  | 184.333ms +0.82% | ±2.70% +213.40% |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.936mb +0.00%  | 18.431ms +0.76%  | ±1.29% +20.40%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.923mb +0.00%  | 1.988ms +4.77%   | ±1.78% -2.38%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.923mb +0.00%  | 1.944ms +7.52%   | ±0.64% -77.25%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 75.035mb +0.00%  | 2.888ms +9.59%   | ±2.61% +324.78% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.564mb +0.00%  | 14.783ms -1.15%  | ±1.75% +24.12%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.564mb +0.00%  | 14.597ms +0.40%  | ±1.28% -19.65%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.468mb +0.00%  | 2.000μs +11.49%  | ±0.00% -100.00% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.468mb +0.00%  | 0.500μs +25.00%  | ±0.00% -100.00% |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 87.023mb +0.00%  | 14.385ms +10.58% | ±2.42% +71.80%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.384mb +0.00% | 66.597ms +1.73%  | ±0.48% -46.57%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 76.084mb +0.00%  | 1.693ms +21.44%  | ±2.48% +164.54% |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.431mb +0.00%  | 59.615ms +0.10%  | ±1.31% +341.00% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 78.185mb +0.00%  | 4.589ms +14.71%  | ±2.80% +113.37% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.546mb +0.00%  | 41.794ms +2.81%  | ±1.07% +187.68% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.547mb +0.00%  | 41.705ms +2.54%  | ±1.69% +102.78% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.546mb +0.00%  | 41.610ms -0.82%  | ±1.04% -29.38%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.910mb +0.00%  | 7.604ms +2.62%   | ±0.14% -84.47%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.468mb +0.00%  | 29.800ms +2.84%  | ±0.20% -68.69%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.468mb +0.00%  | 14.200μs +5.48%  | ±1.15% -59.27%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.468mb +0.00%  | 16.518μs +3.75%  | ±0.85% +8.38%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.477mb +0.00%  | 185.081ms -0.19% | ±1.28% -36.33%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit ee7bfa1 into flow-php:1.x Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant