A small refactoring#235
Merged
fdocr merged 3 commits intoforem:masterfrom Oct 20, 2020
RomanPodymov:master
Merged
Conversation
|
|
chickdan
suggested changes
Oct 17, 2020
Contributor
chickdan
left a comment
chickdan
left a comment
There was a problem hiding this comment.
Hi Roman, thanks for submitting this PR! If you remove the static keyword from seekInterval then you won't need to use Self when referencing that variable. Since the variable isn't used anywhere else I don't see a need for it to be static.
Co-authored-by: Daniel Chick <daniel.chick@hotmail.com>
fdocr
approved these changes
Oct 20, 2020
Contributor
fdocr
left a comment
fdocr
left a comment
There was a problem hiding this comment.
Thank you for the contribution @RomanPodymov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Hello.
Thank you for DEV-ios.
I did a small refactoring in MediaManager.swift.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?