fix(api): fix polling duration wrongfully marshalled#1767
fix(api): fix polling duration wrongfully marshalled#1767paul-nicolas merged 1 commit intoreleases/v2.0.0from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
Context
One of our customers has some problems when getting the config of the Atlar connector. After investigation, it was the custom duration struct that was failing to be marshalled before being sent to the client. A fix has been done a few weeks ago to fix the "pollingPeriod" custom duration in the configs, but Atlar has one more custom duration struct.
Solution
After investigation, it seems that the custom duration struct was not implementing correctly the Marshal interface, which was the cause of the wrong json sent through the api. Fixing this implementation allows us also to remove the api fix we've made.
Fixes PMNT-109