Fix encoding problems caused by camo#826
Merged
SSilence merged 2 commits intofossar:masterfrom Dec 19, 2016
lumiru:patch-3
Merged
Fix encoding problems caused by camo#826SSilence merged 2 commits intofossar:masterfrom lumiru:patch-3
SSilence merged 2 commits intofossar:masterfrom
lumiru:patch-3
Conversation
Loading HTML in DomDocument create encoding issues. Additionally, regex are faster than loading a document tree.
Member
|
Regexes might be slightly faster but are much easier to make mistake. Edit: I misread. |
Contributor
Author
|
Oh sorry, I made a mistake. @jtojnar Please note that the used regex is the same as the one used for delayed image load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading HTML in DomDocument create encoding issues.
Additionally, regex are faster than loading a document tree.
I often found this issue with fulltextrss spout and French feeds.
There might be another problem with encoding with this spout.
Indeed, I get similar problems on selfoss android app even if I apply this fix.