Conversation
Member
Author
|
Fancybox does not work for some reason when the image URL does not end with an image extension 🤷 |
In 2016, Twitter made changes to the API which resulted in tweets being truncated: https://dev.twitter.com/overview/api/upcoming-changes-to-tweets This patch changes the twitter spouts to use the extended mode, allowing for full tweet bodies to be received. Closes: #824
Previously, we used regex for converting URLs to links, which lead to weird errors like #933. This patch uses the entities metadata provided by Twitter, thus the links should correspond to those on Twitter site (including hashtags and mentions). Additionally, the links now use correct href, instead of Twitter’s tracking shortener. https://dev.twitter.com/overview/api/entities-in-twitter-objects
Twitter provides list of pictures in extended_entities field: https://dev.twitter.com/overview/api/entities-in-twitter-objects#media Closes: #823
Member
Author
|
Fancybox is now fixed, tests will be added later when testing framework is chosen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.