Make source code checkers accessible from Grunt#943
Merged
Conversation
jtojnar
force-pushed
the
grunt-checkers
branch
6 times, most recently
from
6b29a1e to
252271e
Compare
Member
Author
|
I do not really like this. I asked on reddit and so far we have two alternatives: |
jtojnar
force-pushed
the
grunt-checkers
branch
3 times, most recently
from
92f6187 to
4ebbc06
Compare
To make the development cycle faster we want developers to be able to run all the required checks locally. Because of the way Composer is designed, we cannot save the checkers as dev dependencies but have to install them separately. Instead of using composer for installing linters to utils directory, we now use the tools from PATH, allowing users to install them using their package manager of choice. For Travis and users running distributions that do not have the checkers packaged, there is `utils/install-phars.sh` helper script, which will install the necessary checkers to ~/.local/bin directory. This commit introduces new grunt tasks: * `lint:server` will check PHP syntax using built-in PHP tool * `cs:server` will check the coding style using PHP-CS-Fixer * `check:server` will run both the checkers (more in the future) * `check` will run both server side and client side checkers
jtojnar
force-pushed
the
grunt-checkers
branch
from
4ebbc06 to
8a1a050
Compare
Member
Author
|
In the end, I have decided to make users install the linters manually, either using a package manager or by calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.