You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 19, 2024. It is now read-only.
I rebuilt the update counter.
When it detects available updates, it saves the update version to the database.
Version checking now takes place only when someone entering the cloud blocks tab in dashboard and once per day using cron.
I also improved some translations and typos.
Before merge, please check if cron works as it should.
register_activation_hook and register_deactivation_hook must be called from the plugins entry file, in our case, its cloud-blocks.php in the plugins root folder.
Creating cronjobs on activation hook is the correct way, but what about those who already activated the plugin? In this case, I think it might be good if it was hooked to upgrader_process_complete action which fires after plugin update.
In the Activator.php file on line 17, you forgot to change $current_db_version. Just change it to a higher number than the current number. This makes sure if there are any changes in the database schema.
You forgot to add class to add_action( 'cron_check_updates', 'check_updates' ); in Explore.phpfile. If you are adding an action hook inside a class method, you must add callback as an array. This action should be like:add_action( 'cron_check_updates', array( CLASS, 'check_updates' ) );`
I moved hooks to entry file and I added init action for wp cron (but calmly, cron events will not be duplicated). - Tested. Works on upgrade, activate and removed on deactivate.
As above. 'init' action resolved this problem.
Changed.
Fixed.
I tested, WP CRON works. Calling the method after entering the cloud blocks tab also works.
In addition, I changed the changelog and increased the version to 1.1.4 everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :)
I rebuilt the update counter.
When it detects available updates, it saves the update version to the database.
Version checking now takes place only when someone entering the cloud blocks tab in dashboard and once per day using cron.
I also improved some translations and typos.
Before merge, please check if cron works as it should.