Ensure mysql rows responses are closed#1132
Merged
timvaillancourt merged 4 commits intogithub:masterfrom Jul 6, 2022
Merged
Conversation
ghost
approved these changes
Jul 6, 2022
ghost
pushed a commit
that referenced
this pull request
Jul 7, 2022
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
Closed
ghost
pushed a commit
that referenced
this pull request
Jul 7, 2022
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures the rows-responses from the MySQL driver are closed by using a
defer rows.Close(), in order to followdatabase/sqlbest practicesAlso, these linters are introduced to ensure we don't have this problem again:
rowserrchecksqlclosecheckThis PR resolves these linter errors:

script/cibuildreturns with no formatting errors, build errors or unit test errors.