Set a transaction isolation level for MySQL connections#1156
Merged
timvaillancourt merged 6 commits intogithub:masterfrom Aug 12, 2022
Merged
Set a transaction isolation level for MySQL connections#1156timvaillancourt merged 6 commits intogithub:masterfrom
timvaillancourt merged 6 commits intogithub:masterfrom
Conversation
Collaborator
Author
|
Hmm works on my laptop, fails in CI. More soon! 🤔 |
timvaillancourt
force-pushed
the
set-trx-isolation
branch
2 times, most recently
from
26948cd to
4820212
Compare
timvaillancourt
force-pushed
the
set-trx-isolation
branch
from
60b4a26 to
b6cc422
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #1155
Description
This PR resolves #1155 by defining a connection-level transaction isolation level when setting up new MySQL connections. I also moved connection params to a slice that's joined into a string later-on because the giant params string was getting pretty unreadable. I also moved cases of
log.Fatalfwith no tokens tolog.Fatal🧹At this time
REPEATABLE_READis used as the isolation for all connections following a discussion here: #1155script/cibuildreturns with no formatting errors, build errors or unit test errors.