Skip to content

Comments

Add basic test for inspector#1166

Merged
timvaillancourt merged 4 commits intogithub:masterfrom
timvaillancourt:logic-inspector-tests
Sep 6, 2022
Merged

Add basic test for inspector#1166
timvaillancourt merged 4 commits intogithub:masterfrom
timvaillancourt:logic-inspector-tests

Conversation

@timvaillancourt
Copy link
Collaborator

@timvaillancourt timvaillancourt commented Aug 15, 2022

Description

This PR adds a simple test for the .getSharedUniqueKeys() func of go/logic/inspector.go

Also, the err error return was removed from .getSharedUniqueKeys() because it is never set

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@timvaillancourt timvaillancourt added this to the v1.1.6 milestone Aug 18, 2022
@timvaillancourt timvaillancourt merged commit 05c7ed5 into github:master Sep 6, 2022
@timvaillancourt timvaillancourt deleted the logic-inspector-tests branch September 6, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant