Update the description of the max-lag-millis in docs#1388
Merged
timvaillancourt merged 3 commits intogithub:masterfrom Mar 12, 2024
Merged
Update the description of the max-lag-millis in docs#1388timvaillancourt merged 3 commits intogithub:masterfrom
timvaillancourt merged 3 commits intogithub:masterfrom
Conversation
Contributor
Author
|
@meiji163 @timvaillancourt @rashiq Can I please request a review? |
timvaillancourt
approved these changes
Mar 12, 2024
Collaborator
timvaillancourt
left a comment
There was a problem hiding this comment.
LGTM, thanks @dontstopbelieveing 🙏
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue: #1387
Description
This PR updates the docs for the description of the max-lag-millis command line parameter, specially in context of running on master
script/cibuildreturns with no formatting errors, build errors or unit test errors.