Ensure -attempt-instant-ddl respects -execute flag#1440
Merged
timvaillancourt merged 1 commit intogithub:masterfrom Aug 14, 2024
Merged
Ensure -attempt-instant-ddl respects -execute flag#1440timvaillancourt merged 1 commit intogithub:masterfrom
-attempt-instant-ddl respects -execute flag#1440timvaillancourt merged 1 commit intogithub:masterfrom
Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
meiji163
approved these changes
Aug 14, 2024
YazanAlnasr
approved these changes
Aug 14, 2024
hakusaro
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR partially addresses #1365 by ensuring the
-attempt-online-ddlfeature respects the-executeflagscript/cibuildreturns with no formatting errors, build errors or unit test errors.