Move successful cleanup into func#1520
Merged
meiji163 merged 3 commits intogithub:masterfrom Apr 7, 2025
pasha132:fix-instant-cleanup
Merged
Move successful cleanup into func#1520meiji163 merged 3 commits intogithub:masterfrom pasha132:fix-instant-cleanup
meiji163 merged 3 commits intogithub:masterfrom
pasha132:fix-instant-cleanup
Conversation
pasha132
requested review from
meiji163,
rashiq and
timvaillancourt
as code owners
meiji163
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #1510
Description
Trying to fix inconsistent behavior between instant and usual ways of migrating.
script/cibuildreturns with no formatting errors, build errors or unit test errors.