Align max --dml-batch-size with the implementation#1575
Merged
meiji163 merged 1 commit intogithub:masterfrom Aug 12, 2025
Merged
Align max --dml-batch-size with the implementation#1575meiji163 merged 1 commit intogithub:masterfrom
--dml-batch-size with the implementation#1575meiji163 merged 1 commit intogithub:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the upper limit of the --dml-batch-size flag from 100 to 1000 to align the documentation and command-line help text with the actual implementation, which has supported up to 1000 since 2017.
- Updated the command-line flag description in main.go to reflect the correct upper limit
- Updated the documentation to match the implementation's actual supported range
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/cmd/gh-ost/main.go | Updated dml-batch-size flag description to show correct range (1-1000) |
| doc/command-line-flags.md | Updated documentation to reflect the actual supported range for dml-batch-size |
--zdml-batch-size with the implementation
--zdml-batch-size with the implementation--dml-batch-size with the implementation
meiji163
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue: None
Description
This PR updates the upper limit of the
--dml-batch-sizeflag from100to1000to match the actual implementation.The upper limit of
--dml-batch-sizehas not changed since 2017.ref: #438
gh-ost/go/base/context.go
Lines 645 to 652 in 7c3b9a1
gh-ost/go/base/context.go
Line 54 in 7c3b9a1
script/cibuildreturns with no formatting errors, build errors or unit test errors.