Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new sysbench localtest to enable testing gh-ost under heavier write workloads. The test is extracted from another PR for reusability in debugging scenarios.
- Adds sysbench test functionality that can be skipped if sysbench binary is not available
- Refactors hardcoded table names to use variables for flexibility
- Installs sysbench in the CI environment to support the new test
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| localtests/test.sh | Adds sysbench test logic, variables for table names, and cleanup functionality |
| localtests/sysbench/create.sql | Creates sysbench test directory with table structure documentation |
| .github/workflows/replica-tests.yml | Installs sysbench package in CI environment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mhamza15
previously approved these changes
Oct 8, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mhamza15
approved these changes
Oct 8, 2025
meiji163
added a commit
that referenced
this pull request
Oct 10, 2025
* add sysbench localtest * fix table name * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * ensure cleanup --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
meiji163
added a commit
that referenced
this pull request
Oct 10, 2025
…ly (#1594) * Panic if InitiateHeartbeat exhausts retries to avoid looping infinitely. Based on experience, if the writer database fails inbeetween the copy & cutover stages (e.g. during cutover pause), the heartbeat writes will fail and stop, then leading to throttled state and an infinite loop of throttler.shouldThrottle(). Since this state is irrecoverable, make the heartbeat writer panic if retries are exhausted, so that the migration can fail and be restarted later. * Add sysbench localtest (#1590) * add sysbench localtest * fix table name * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * ensure cleanup --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * add toxiproxy option for localtests (#1591) --------- Co-authored-by: Jan Grodowski <jan.grodowski@shopify.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts the sysbench localtest from #1584 so we can use it for debugging elsewhere. It is useful for testing gh-ost locally under heavier & more complex write workload.
The test is skipped unless
sysbenchbinary is in yourPATH.script/cibuildreturns with no formatting errors, build errors or unit test errors.