implement a logging interface#789
Conversation
|
@shlomi-noach I noticed you've taken some action to update this pull request, looks like it has passed all the checks. Can we merge this pull request? |
|
👋 @abeyum indeed I did. I'm rotating between a few issues/PRs. I apologize, but I'm still going to push this a bit, and would only be able to look into it again after end of year. I appreciate your PR and the time you took to write it. |
|
Hello @shlomi-noach, Any chance you are free to take a look and merge? PR has passed all checks and there are no merge conflicts. |
|
ping @jfudally. Is this something you can look at? |
|
Hi there. I'm responding because I was @-mentioned directly. I no longer work at GitHub, am no longer an owner of this repository, and am actually not working right now. I'm taking a personal break from |
|
@jfudally Any chance we can review and merge this soon? |
|
@abeyum Thank you for the submission, I appreciate the work you put into this. Sorry it's taken so long to get this in! |
Description
Related issue: #786
This PR allows developers to write gh-ost logs to where they see fit by extending an interface instead of relying on the default outbrain logs.
cc: @shlomi-noach