Create publish-gem.yml#898

tsusdere · 2024-01-02T19:11:39Z

Adds workflow to automate publishing the gem to RubyGems

YiMysty · 2024-01-02T21:31:01Z

.github/workflows/publish-gem.yml

Suggested change

ruby-version: '3.2'

ruby-version: '2.7.3'

parkr · 2024-01-02T21:40:55Z

.github/workflows/publish-gem.yml

Is there any reason not to release on a later version? At least worthwhile to use 2.7.8 to get the bug and security fixes.

👋 @parkr do you think if we can move to ruby 3.0 for this project? yeh we can move to 2.7.8

To add seems the same problem with CI can be seen with other repos (regarding Ruby version):
https://github.com/pages-themes/midnight/actions/runs/7391072383/job/20107215490?pr=50

I think we should go to 3.2 at least, but there might be bugs to fix along the way.

YiMysty · 2024-01-02T21:50:27Z

.github/workflows/publish-gem.yml

+      - name: Build gem
+        run: |
+          gem build github-pages.gemspec
+      - name: Publish


this should only run when merge into master branch or tag release I think?

Do we want to instead run the job when we merge into master branch?

on: push: branches: - main

on: release: types: [released]

parkr · 2024-01-04T19:12:54Z

Dockerfile

Since you're upgrading in this PR, you can probably remove this.

parkr · 2024-01-04T19:13:47Z

.github/workflows/push.yml

Quote these so they become strings when parsed rather than floats.

parkr · 2024-01-04T19:14:07Z

.travis.yml

I think you can remove this Travis config file entirely.

parkr · 2024-01-04T19:15:27Z

Ruby 3.3 support is added by #897. That needs to be merged first!

parkr · 2024-01-04T19:17:44Z

Dockerfile.alpine

@@ -1,4 +1,4 @@
-FROM ruby:2.7.3-alpine
+FROM ruby:3.3-alpine


I believe CI is attempting to pass the RUBY_VERSION build arg, but here it's always ruby 3.3.

Either remove the RUBY_VERSION arg from CI and script/cibuild-docker or support it here in Dockerfile.

parkr · 2024-01-05T18:50:11Z

lib/github-pages/dependencies.rb


      {
-        "ruby" => RUBY_VERSION,
+        "ruby" => "3.3",


This will show unexpected values for non-Ruby 3.3 CI.

tsusdere added 4 commits January 2, 2024 13:11

Create publish-gem.yml

f3ee583

add ruby version

bb1d50e

Update publish-gem.yml

ecb7a8a

Update publish-gem.yml

31bce95

tsusdere marked this pull request as ready for review January 2, 2024 19:26

YiMysty reviewed Jan 2, 2024

View reviewed changes

.github/workflows/publish-gem.yml Outdated

Copy link

Contributor

YiMysty Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

ruby-version: '3.2'

ruby-version: '2.7.3'

tsusdere added 3 commits January 2, 2024 15:32

Update Dockerfile

2d66a27

Update Dockerfile

351e4a7

Update publish-gem.yml

8c97daf

parkr reviewed Jan 2, 2024

View reviewed changes

YiMysty added 2 commits January 2, 2024 13:45

update gem update

7337649

upgrade to 2.7.8

549fa79

YiMysty reviewed Jan 2, 2024

View reviewed changes

tsusdere added 11 commits January 2, 2024 16:03

Update publish-gem.yml

d7615e1

change ruby version

a1e407c

add version to update

3980c1a

revert to working update

90b989b

add 3.2

7c86cdb

remove 2.6

d73437f

Update push.yml

9ccadb7

Update .travis.yml

8dd7a80

test 3.4 for CI

48da3d2

update version

460897f

update

798d778

parkr approved these changes Jan 4, 2024

View reviewed changes

parkr reviewed Jan 4, 2024

View reviewed changes

tsusdere added 3 commits January 4, 2024 18:18

change ruby version

fa1b540

update jekyll

117fd75

Update cibuild-docker

ed0d437

tsusdere added 3 commits January 4, 2024 18:27

Update .rubocop.yml

91e261d

Update github-pages.gemspec

c31c982

Update Gemfile

47322fd

parkr approved these changes Jan 5, 2024

View reviewed changes

lib/github-pages/dependencies.rb

{

"ruby" => RUBY_VERSION,

"ruby" => "3.3",

Copy link

Contributor

parkr Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will show unexpected values for non-Ruby 3.3 CI.

YiMysty approved these changes Jan 9, 2024

View reviewed changes

tsusdere merged commit 974872f into master Jan 9, 2024

tsusdere deleted the publishing-workflow branch January 9, 2024 22:20

yoannchaudet mentioned this pull request Feb 6, 2024

Bump jekyll to v3.9.4 #897

Closed

nate2014jatc mentioned this pull request Feb 12, 2024

Bump jekyll-feed and github-pages nate2014jatc/AGSTATUS#20

Merged

mrmanc mentioned this pull request Apr 5, 2024

Add webrick as Ruby 3 doesn’t include it #914

Merged

Conversation

tsusdere commented Jan 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YiMysty Jan 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parkr commented Jan 4, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

tsusdere commented Jan 2, 2024 •

edited

Loading

YiMysty Jan 2, 2024 •

edited

Loading