Skip to content

gh-996: Fix bug in apply_along_axis #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paddyroddy merged 2 commits into from
Jan 23, 2026
Merged

gh-996: Fix bug in apply_along_axis #997

paddyroddy merged 2 commits into from
Jan 23, 2026

Conversation

@paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Jan 23, 2026 •
edited
Loading

Description

This PR fixes a subtle bug within apply_along_axis that causes the array passed to partial (in this case interp) to be outputted as a NumPy array causing a mismatch between this and array-api-strict. I wanted to test this, but really not sure how to do that.

Fixes: #996

Changelog entry

Fixed: apply_along_axis from XPAddtions now has consistent array types

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@paddyroddy paddyroddy self-assigned this Jan 23, 2026
@paddyroddy paddyroddy added bug Something isn't working array-api Work is related to the Array API labels Jan 23, 2026
@paddyroddy paddyroddy requested a review from connoraird January 23, 2026 17:27
connoraird
connoraird approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@connoraird connoraird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@paddyroddy paddyroddy merged commit 21ac3cf into main Jan 23, 2026
25 checks passed
@paddyroddy paddyroddy deleted the paddy/issue-996 branch January 23, 2026 17:54
@paddyroddy paddyroddy mentioned this pull request Jan 26, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connoraird connoraird connoraird approved these changes

Assignees

@paddyroddy paddyroddy

Labels

array-api Work is related to the Array API bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

XPAdditions.apply_along_axis fails with array_api_strict

3 participants

@paddyroddy @connoraird