Skip to content

cmd/auth/cookieauth: delete unreachable os.Exit#388

Closed
Abirdcfly wants to merge 1 commit intogolang:masterfrom
Abirdcfly:master
Closed

cmd/auth/cookieauth: delete unreachable os.Exit#388
Abirdcfly wants to merge 1 commit intogolang:masterfrom
Abirdcfly:master

Conversation

@Abirdcfly
Copy link
Contributor

@Abirdcfly Abirdcfly commented Jul 21, 2022

No description provided.

@gopherbot
Copy link
Contributor

gopherbot commented Jul 21, 2022

This PR (HEAD: cb0eca5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/418854 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Jul 25, 2022

Message from Bryan Mills:

Patch Set 1: Run-TryBot+1 Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/418854.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 25, 2022

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/418854.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 25, 2022

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/c9484cb4-19e4-4c90-8d87-575df84b70d6

Please don’t reply on this GitHub thread. Visit golang.org/cl/418854.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Jul 25, 2022

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/c9484cb4-19e4-4c90-8d87-575df84b70d6

Please don’t reply on this GitHub thread. Visit golang.org/cl/418854.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jul 25, 2022
@Abirdcfly @gopherbot
cmd/auth/cookieauth: delete unreachable os.Exit
4375b29 
Change-Id: I5c60eeb8667423544b2bc8b9cf5f51279b0a941d
GitHub-Last-Rev: cb0eca5
GitHub-Pull-Request: #388
Reviewed-on: https://go-review.googlesource.com/c/tools/+/418854
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link
Contributor

gopherbot commented Jul 25, 2022

This PR is being closed because golang.org/cl/418854 has been merged.

@gopherbot gopherbot closed this Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Abirdcfly @gopherbot