[ci] In check_todo.sh, permit disabling check

[joshlf]

Support TODO-check-disable and TODO-check-enable to toggle the check within a particular file.

gherrit-pr-id: I0ca32fb0b6e87d3be51ff69487a4f221c0a9ee45

[gemini-code-assist]

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the continuous integration process by providing a mechanism to selectively disable the TODO marker check within source files. This change offers greater flexibility for developers who need to temporarily include TODO comments without triggering CI failures, while still maintaining the overall policy of discouraging TODOs in merged code.

Highlights

• Conditional TODO Checking: The CI script check_todo.sh now supports TODO-check-disable and TODO-check-enable markers, allowing developers to temporarily bypass TODO enforcement within specific code sections.
• Enhanced Script Logic: The check_todo.sh script has been refactored to parse rg output, track the disabled state per file, and conditionally report TODO markers, providing more granular control over the check.
• Improved User Guidance: The error message displayed when TODO markers are found now includes instructions on how to use the new disable/enable directives.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a useful feature to temporarily disable TODO checks within files using TODO-check-disable and TODO-check-enable comments. The overall approach is sound, but I've identified a few areas for improvement to enhance the script's robustness and correctness. My main concerns are the use of the --no-ignore flag with rg, which could lead to false positives in ignored files, and the method used for parsing rg's output, which is not safe for filenames containing colons. I've provided specific suggestions to address these points.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.14%. Comparing base (8134d9e) to head (50d4ccb).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2839   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files          20       20           
  Lines        5450     5450           
=======================================
  Hits         4804     4804           
  Misses        646      646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.