fix(storage): Increase AsyncWriter default MinLwmValue to avoid frequent flushes#15552
Merged
shubham-up-47 merged 6 commits intogoogleapis:mainfrom Sep 23, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15552 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 2408 2408
Lines 220145 220145
=======================================
Hits 204829 204829
Misses 15316 15316 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rajeevpodar
approved these changes
Sep 18, 2025
scotthart
approved these changes
Sep 23, 2025
Member
scotthart
left a comment
There was a problem hiding this comment.
@scotthart reviewed 1 of 1 files at r1, 3 of 3 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @shubham-up-47)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AsyncWriter was using small values of LWM (256 KiB) and HWM (512 KiB). This caused the writer to flush data far too frequently, creating a bottleneck,
This PR increases the default MinLwmValue from 256 KiB to 16 MiB which significantly reduce the number of flush operations, allowing the AsyncWriter to batch more data and achieve much higher throughput. The new default is chosen based on Nokoro test results which demonstrated optimal performance at 16 MiB,
This change is