feat(storage): Add samples related to AppendableObject and OpenObject#15563
Merged
shubham-up-47 merged 6 commits intogoogleapis:mainfrom Oct 3, 2025
Merged
feat(storage): Add samples related to AppendableObject and OpenObject#15563shubham-up-47 merged 6 commits intogoogleapis:mainfrom
shubham-up-47 merged 6 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
api: storage
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15563 +/- ##
==========================================
+ Coverage 93.05% 93.07% +0.01%
==========================================
Files 2414 2414
Lines 221063 221114 +51
==========================================
+ Hits 205720 205795 +75
+ Misses 15343 15319 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shubham-up-47
force-pushed
the
fastbyte_samples
branch
from
a61762d to
f0acefb
Compare
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
bajajneha27
reviewed
Sep 29, 2025
| futures.push_back(count_newlines(std::move(reader), std::move(token))); | ||
| } | ||
|
|
||
| // Wait for all futures and print results |
Contributor
There was a problem hiding this comment.
nit: I think we should not be waiting for all the futures to be ready, we should just start reading the futures which are ready.
Contributor
Author
There was a problem hiding this comment.
Done, please re-check.
nidhiii-27
reviewed
Sep 29, 2025
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
shubham-up-47
temporarily deployed
to
external
GitHub Actions
Inactive
bajajneha27
approved these changes
Sep 29, 2025
Contributor
bajajneha27
left a comment
bajajneha27
left a comment
There was a problem hiding this comment.
Just get alignment on region tags, rest everything looks good to me.
nidhiii-27
approved these changes
Sep 29, 2025
scotthart
approved these changes
Oct 2, 2025
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
@scotthart reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @bajajneha27)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is